Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document how to write crash tests #14602

Closed
foolip opened this issue Dec 19, 2018 · 3 comments
Closed

Document how to write crash tests #14602

foolip opened this issue Dec 19, 2018 · 3 comments
Labels
docs

Comments

@foolip
Copy link
Member

foolip commented Dec 19, 2018

@progers was wondering if/how to write crash tests in web-platform-tests. I wrote:

I'd say just structure it like a reftest or a testharness.js test that does as little as necessary, and runs as long as necessary for the crash to happen if the bug is there. For testharness.js, that may mean a pretty vacuous async_test or similar, but a dummy assert wouldn't really make it clearer what the test is for.

If others agree with this, we should document it.
@foolip foolip added the docs label Dec 19, 2018
@jgraham
Copy link
Contributor

jgraham commented Dec 19, 2018

If you structure things as a single-page test then you possibly just need to call done() at some point before the timeout. One can also imagine making .crash. tests that work like testharness tests except that they can't time out only pass (but maybe it should be a different type altogether that doesn't require having a testharness script).

@foolip
Copy link
Member Author

foolip commented Oct 17, 2019

web-platform-tests/rfcs#33 should resolve this.

@stephenmcgruer
Copy link
Contributor

That rfc merged a while ago, and https://web-platform-tests.org/writing-tests/crashtest.html exists, so I think this is fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@stephenmcgruer @jgraham @foolip