Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.py-multihash: init at 0.2.3 #83203

Merged
merged 1 commit into from Apr 13, 2020
Merged

pythonPackages.py-multihash: init at 0.2.3 #83203

merged 1 commit into from Apr 13, 2020

Conversation

Rakesh4G
Copy link
Contributor

@Rakesh4G Rakesh4G commented Mar 23, 2020 •
edited

Motivation for this change

pythonPackages.py-multihash: init at 0.2.3

Depends On:
#83202
#83200
#83197

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Rakesh4G Rakesh4G changed the title python3Packages.py-multihash: init at 0.2.3 pythonPackages.py-multihash: init at 0.2.3 Mar 23, 2020
This was referenced Mar 23, 2020
Merged
Merged
Merged
jonringer
jonringer reviewed Mar 23, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if upstream correctly declared the right package metadata

pkgs/development/python-modules/py-multihash/default.nix Outdated Show resolved Hide resolved
@Rakesh4G Rakesh4G force-pushed the py-multihash branch 2 times, most recently from a266719 to 4205b47 Compare March 24, 2020 08:05
@jonringer
Copy link
Contributor

please see the reviews of the other two pr's, they are still blocking this PR

@Rakesh4G
Copy link
Contributor Author

Rakesh4G commented Apr 1, 2020

please see the reviews of the other two pr's, they are still blocking this PR

ok. Thanks.

@Rakesh4G Rakesh4G force-pushed the py-multihash branch 3 times, most recently from f8dc6f5 to 59e350a Compare April 9, 2020 17:43
@CMCDragonkai
Copy link
Member

Is this ready to be merged?

jonringer
jonringer approved these changes Apr 13, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 83203 1

1 package failed to build: - python27Packages.py-multihash
2 package built: - python37Packages.py-multihash - python38Packages.py-multihash

@jonringer jonringer merged commit a965581 into NixOS:master Apr 13, 2020
@Rakesh4G Rakesh4G deleted the py-multihash branch April 15, 2020 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Rakesh4G @jonringer @CMCDragonkai