Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vdr-xineliboutput fix build and 2.1.0 -> 2.2.0 #83129

Merged
merged 2 commits into from Mar 23, 2020
Merged

vdr-xineliboutput fix build and 2.1.0 -> 2.2.0 #83129

merged 2 commits into from Mar 23, 2020

Conversation

ck3d
Copy link
Contributor

@ck3d ck3d commented Mar 22, 2020 •
edited

Motivation for this change

The package was broken. Additional updated to 2.2.0.
I will cherry pick this fix for nixos-20.03 when this PR is merged.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ckesg
vdr-xinelinboutput: fix pkg-config for opengl
d315b3d 
Up to including nixos-19.09 configure fall back and included right
libraries. Since nixos-20.03 pkg-config returns a valid value for opengl, but
opengl misses glx symbols.
@ck3d
Copy link
Contributor Author

ck3d commented Mar 22, 2020

cc @markuskowa

@ck3d ck3d force-pushed the unstable-vdr-xineliboutput-fix-opengl-and-2.2.0 branch from b22b7e3 to b7dad49 Compare March 22, 2020 20:23
@markuskowa
Copy link
Member

markuskowa commented Mar 23, 2020 •
edited

@GrahamcOfBorg build vdrPlugins.xineliboutput

@markuskowa markuskowa merged commit 3578bb5 into NixOS:master Mar 23, 2020
@markuskowa
Copy link
Member

markuskowa commented Mar 23, 2020 •
edited

backported to 20.03 in
1a8cc07 and
2762ade

ZHF #80379

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markuskowa markuskowa markuskowa left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ck3d @markuskowa @ckesg