Skip to content

pythonPackages.python-baseconv: init at 1.2.2 #83275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 8, 2020
Merged

pythonPackages.python-baseconv: init at 1.2.2 #83275

merged 1 commit into from
Apr 8, 2020
+24 −0

Conversation

Rakesh4G
Copy link
Contributor

@Rakesh4G Rakesh4G commented Mar 24, 2020 •
edited
Loading

Motivation for this change

pythonPackages.python-baseconv: init at 1.2.2
needed by py-multibase #83276

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@Rakesh4G Rakesh4G changed the title python-baseconv: init at 1.2.2 pythonPackages.python-baseconv: init at 1.2.2 Mar 24, 2020
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Mar 24, 2020
@Rakesh4G Rakesh4G mentioned this pull request Mar 24, 2020
Merged
10 tasks
@wd15
Copy link
Contributor

wd15 commented Mar 24, 2020

Builds for me on Ubuntu x86_64

Result of nixpkgs-review pr 83275 1

3 package built:
  • python27Packages.python-baseconv
  • python37Packages.python-baseconv
  • python38Packages.python-baseconv

jonringer
jonringer approved these changes Apr 8, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 83275 1

3 packages built: - python27Packages.python-baseconv - python37Packages.python-baseconv - python38Packages.python-baseconv

@jonringer jonringer merged commit 9449ee6 into NixOS:master Apr 8, 2020
@Rakesh4G Rakesh4G deleted the python-baseconv branch April 15, 2020 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer

@FRidh FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Rakesh4G @wd15 @jonringer