Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python38Packages.rope: disable for Python>=3.8 #83012

Merged
merged 1 commit into from Mar 23, 2020

Conversation

bcdarwin
Copy link
Member

@bcdarwin bcdarwin commented Mar 20, 2020

  • browsing the github page suggests the upcoming 0.17 release should support 3.8

for ZHF: #80379

backport of #83009

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bcdarwin
Copy link
Member Author

cc @NixOS/nixos-release-managers

- browsing the github page suggests the upcoming 0.17 release should support 3.8

(cherry picked from commit 3d0410e)
@worldofpeace
Copy link
Contributor

The default interpreter is still 3.7 btw.

@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build python38Packages.rope

@worldofpeace worldofpeace merged commit 017f050 into NixOS:release-20.03 Mar 23, 2020
@bcdarwin bcdarwin deleted the release-20.03 branch March 23, 2020 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants