Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

atlassian-jira: 8.7.1 - 8.8.0 #83218

Merged
merged 1 commit into from Mar 28, 2020
Merged

atlassian-jira: 8.7.1 - 8.8.0 #83218

merged 1 commit into from Mar 28, 2020

Conversation

basilgood
Copy link
Contributor

update: 8.7.1 -> 8.8.0
fix: not starting service when jdk is jdk11

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@basilgood
atlassian-jira: 8.7.1 - 8.8.0
c916030 
fix not starting service when jdk is jdk11
@ofborg ofborg bot requested review from fpletz, globin and ciil March 23, 2020 14:39
megheaiulian
megheaiulian approved these changes Mar 24, 2020
View reviewed changes
Copy link
Contributor

@megheaiulian megheaiulian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested this update with openjdk 11 and everything seems to work correctly.

ciil
ciil approved these changes Mar 25, 2020
View reviewed changes
Copy link
Member

@ciil ciil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@globin globin merged commit 758f81d into NixOS:master Mar 28, 2020
@megheaiulian megheaiulian deleted the feature/atlassian-jira-fix-and-update branch March 28, 2020 09:29
globin pushed a commit that referenced this pull request Mar 28, 2020
@basilgood @globin
atlassian-jira: 8.7.1 -> 8.8.0 (#83218)
f1c1247 
fix not starting service when jdk is jdk11

(cherry picked from commit 758f81d)
stigok pushed a commit to stigok/nixpkgs that referenced this pull request Jun 12, 2020
@basilgood @stigok
atlassian-jira: 8.7.1 -> 8.8.0 (NixOS#83218)
c99ffc8 
fix not starting service when jdk is jdk11

(cherry picked from commit 758f81d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@megheaiulian megheaiulian megheaiulian approved these changes

@ciil ciil ciil approved these changes

@fpletz fpletz Awaiting requested review from fpletz

@globin globin Awaiting requested review from globin

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@basilgood @megheaiulian @ciil @globin