Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kitty: 0.16.0 -> 0.17.1 #83282

Merged
merged 1 commit into from Mar 24, 2020
Merged

kitty: 0.16.0 -> 0.17.1 #83282

merged 1 commit into from Mar 24, 2020

Conversation

Luflosi
Copy link
Contributor

@Luflosi Luflosi commented Mar 24, 2020 •
edited

Motivation for this change

https://github.com/kovidgoyal/kitty/releases/tag/v0.17.1

The png2icns patch is no longer needed because kitty will now automatically use png2icns when iconutil cannot be found.
The zsh completions will now work without needing to invoke them with source, which means, that we can just install them like the other shell completions.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from Ma27 and tex March 24, 2020 12:13
@jtojnar
Copy link
Contributor

jtojnar commented Mar 24, 2020 •
edited

https://github.com/kovidgoyal/kitty/releases/tag/v0.17.1 was just released

https://sw.kovidgoyal.net/kitty/changelog.html

@Luflosi
Copy link
Contributor Author

Luflosi commented Mar 24, 2020

Should we skip 0.17.0?

@jtojnar
Copy link
Contributor

jtojnar commented Mar 24, 2020 •
edited

It will not really be skipped since changes in 0.17.0 are part of 0.17.1. It is easier to just re-use the same PR. Especially since the release fixes some issues introduced in 0.17.1.

@Luflosi
Copy link
Contributor Author

Luflosi commented Mar 24, 2020

Ok, I'll just add another commit and change the title then.

@jtojnar
Copy link
Contributor

jtojnar commented Mar 24, 2020

For just minor bump, it is not even necessary to use a separate commit, you can just amend the previous one. Separate commits are only necessary when they improve the clarity by making the incremental diffs smaller.

@Luflosi
kitty: 0.16.0 -> 0.17.1
66b9e5d 
https://github.com/kovidgoyal/kitty/releases/tag/v0.17.1

The png2icns patch is no longer needed because kitty will now automatically use `png2icns` when `iconutil` cannot be found.
The zsh completions will now work without needing to invoke them with `source`, which means, that we can just install them like the other shell completions.
@Luflosi Luflosi changed the title kitty: 0.16.0 -> 0.17.0 kitty: 0.16.0 -> 0.17.1 Mar 24, 2020
@Luflosi
Copy link
Contributor Author

Luflosi commented Mar 24, 2020

Ok, I did that and while I was at it I rebased onto the latest master.

@KamilaBorowska
Copy link
Member

That was a fast update, when I checked, there was no 0.17.1 release :).

@teto teto merged commit 4ed9853 into NixOS:master Mar 24, 2020
@Luflosi Luflosi deleted the update/kitty branch March 24, 2020 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KamilaBorowska KamilaBorowska KamilaBorowska approved these changes

@Ma27 Ma27 Awaiting requested review from Ma27

@tex tex Awaiting requested review from tex

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Luflosi @jtojnar @KamilaBorowska @teto