onedrive: 2.3.13 -> 2.4.0 #83280
onedrive: 2.3.13 -> 2.4.0 #83280
Conversation
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/best-practice-for-handling-a-breaking-update-to-a-derivation/6365/4 |
|
we can start a convention to put some keyword to commit message, which can warrant users about incoming breaking changes. Candidate words: cc @worldofpeace about idea to add such keyword to commit message, for future benefit of unstable users. |
Doesn't Rust do this and have tooling on top of it? |
|
@worldofpeace sorry, I'm not aware of that. Which tooling? |
| @@ -108,6 +108,11 @@ | |||
| <link linkend="opt-security.duosec.integrationKey">security.duosec.integrationKey</link>. | |||
| </para> | |||
| </listitem> | |||
| <listitem> | |||
| <para> | |||
| The package <package>onedrive</package> needs the end user to reauthorize the client for all the accounts. Details <link xlink:href="https://github.com/abraunegg/onedrive/issues/835">here</link>. | |||
There was a problem hiding this comment.
"here" isn't great context for links.
Can we use something like the following instead?
Details can be found in onedrive's <link xlink:href="https://github.com/abraunegg/onedrive/issues/835">GitHub issue #835</link>.
I feel that this PR doesn't contain breaking changes in the traditional sense. It's more like, users need to be aware that action will be required. It might have been good if the PR's description had a "Reviewer's Note: ..." or similar, just to double make sure they are aware of the need to re-auth, and maybe mention that it's easy to reset back to previous auth with another However, I don't think there's any way of letting true end users know about the requirement to re-auth other than in the release notes is there? |
|
@danbst do you want to approve this? |
|
Probably too casual, sorry :) If you can approve this, its better than these changes go in than the automated changes in #86707 |
Motivation for this change
Upgrade
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)