Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python37Packages.spyder: 4.0.1 -> 4.1.1 (and unbreak with Python3) #83038

Merged
merged 3 commits into from Mar 23, 2020

Conversation

bcdarwin
Copy link
Member

@bcdarwin bcdarwin commented Mar 20, 2020

Motivation for this change

cc @marcus7070

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bcdarwin
Copy link
Member Author

bcdarwin commented Mar 20, 2020

May be worth an attempt to backport to 20.03 for #80379 (ZHF).

@bcdarwin
Copy link
Member Author

@FRidh -- all resolved, thanks.

@marcus7070
Copy link
Member

Thanks @bcdarwin, I've checked out this PR and spyder works fine for me, under Wayland as well.

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

[15 built, 22 copied (19.9 MiB), 3.5 MiB DL]
https://github.com/NixOS/nixpkgs/pull/83038
4 package marked as broken and skipped:
python38Packages.pyls-isort python38Packages.pyls-mypy python38Packages.python-language-server python38Packages.spyder

10 package built:
python27Packages.pyls-isort python27Packages.python-language-server python27Packages.spyder-kernels python37Packages.pyls-black python37Packages.pyls-isort python37Packages.pyls-mypy python37Packages.python-language-server spyder python37Packages.spyder-kernels python38Packages.spyder-kernels

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

[15 built, 22 copied (19.9 MiB), 3.5 MiB DL]
https://github.com/NixOS/nixpkgs/pull/83038
4 package marked as broken and skipped:
python38Packages.pyls-isort python38Packages.pyls-mypy python38Packages.python-language-server python38Packages.spyder

10 package built:
python27Packages.pyls-isort python27Packages.python-language-server python27Packages.spyder-kernels python37Packages.pyls-black python37Packages.pyls-isort python37Packages.pyls-mypy python37Packages.python-language-server spyder python37Packages.spyder-kernels python38Packages.spyder-kernels

@jonringer jonringer merged commit 353c6c9 into NixOS:master Mar 23, 2020
@bcdarwin bcdarwin deleted the update-spyder branch March 23, 2020 17:52
@bcdarwin bcdarwin mentioned this pull request Apr 17, 2020
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants