Fix error handling when calling replace/replaceSync on a non-constructed sheet. #22405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Mar 23, 2020
…ted sheet. See WICG/construct-stylesheets#62 for the rejected promise bit. On top of that we were not returning so we were incorrectly applying the styles. Bug: 1063809 Change-Id: I63aa937f66871e3b8eee577a7f2ddd873f45d2c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116092 Commit-Queue: Emilio Cobos Álvarez <emilio@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Auto-Submit: Emilio Cobos Álvarez <emilio@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#752591}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2116092
branch
from
9ca3859
to
03e4092
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See WICG/construct-stylesheets#62 for the rejected
promise bit. On top of that we were not returning so we were incorrectly
applying the styles.
Bug: 1063809
Change-Id: I63aa937f66871e3b8eee577a7f2ddd873f45d2c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116092
Commit-Queue: Emilio Cobos Álvarez <emilio@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Auto-Submit: Emilio Cobos Álvarez <emilio@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#752591}