Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qgnomeplatform: hardcode gsettings schemas #83245

Merged
merged 1 commit into from Apr 1, 2020

Conversation

worldofpeace
Copy link
Contributor

Fixes #81866

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

@lovesegfault lovesegfault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works flawlessly!

@worldofpeace worldofpeace mentioned this pull request Mar 31, 2020
10 tasks
@jtojnar
Copy link
Contributor

jtojnar commented Apr 1, 2020

Moved the schema initialization from initializer lists inside the constructor, where the auxiliary objects will be unref’d upon leaving the stack frame (thanks to the magic of g_autoptr). Not sure if fetching also FedoraQt/QGnomePlatform@db2afbe is worth it.

@worldofpeace
Copy link
Contributor Author

Moved the schema initialization from initializer lists inside the constructor, where the auxiliary objects will be unref’d upon leaving the stack frame (thanks to the magic of g_autoptr). Not sure if fetching also FedoraQt/QGnomePlatform@db2afbe is worth it.

Thanks soo much ✨

@worldofpeace
Copy link
Contributor Author

eval problem is unrelated #83929

@worldofpeace worldofpeace merged commit e6afda4 into NixOS:master Apr 1, 2020
@worldofpeace worldofpeace deleted the qgnomeplatform-patch branch April 1, 2020 06:16
@worldofpeace
Copy link
Contributor Author

backported to 20.03 in 33c19df

@jtojnar
Copy link
Contributor

jtojnar commented Apr 1, 2020

Note that I did not test it other than by building it.

@worldofpeace
Copy link
Contributor Author

Note that I did not test it other than by building it.

Ohh, I should have mentioned it before I merged. I did test it on a Pantheon system, but I actually couldn't reproduce the issue before and after when running a program in a shell with unset XDG_DATA_DIRS. I guess I'll leave that up to @lovesegfault to find out. (I tested it with vlc)

@ghost
Copy link

ghost commented Apr 1, 2020

@worldofpeace It fixes issue for me

@lovesegfault
Copy link
Member

It works for myself as well :)

@worldofpeace
Copy link
Contributor Author

Ohh, forgot to backport. Will do this.

@ghost
Copy link

ghost commented Apr 4, 2020

@jtojnar @worldofpeace
Found an issue with this solution:

  1. Start i3wm
  2. Launch VLC via dmenu
  3. Click Media - Open file (Ctrl + O)
    Boom - crash!

@worldofpeace
Copy link
Contributor Author

That is actually within gtk. So it isn't related to this exact fix.

@jtojnar Could we just hardcode those one's in gtk?

@jtojnar
Copy link
Contributor

jtojnar commented Apr 4, 2020

Yes, that's what I wanted to do, just did not get to it yet. Though, I believe GTK also depends on gsettings-desktop-schemas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

qgnomeplatform requires gsettings-desktop-schemas
3 participants