New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qgnomeplatform: hardcode gsettings schemas #83245
Conversation
08f2830
to
1bd0fe5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works flawlessly!
pkgs/development/libraries/qgnomeplatform/hardcode-gsettings.patch
Outdated
Show resolved
Hide resolved
pkgs/development/libraries/qgnomeplatform/hardcode-gsettings.patch
Outdated
Show resolved
Hide resolved
1bd0fe5
to
0ea6866
Compare
Moved the schema initialization from initializer lists inside the constructor, where the auxiliary objects will be unref’d upon leaving the stack frame (thanks to the magic of |
Thanks soo much ✨ |
eval problem is unrelated #83929 |
backported to 20.03 in 33c19df |
Note that I did not test it other than by building it. |
Ohh, I should have mentioned it before I merged. I did test it on a Pantheon system, but I actually couldn't reproduce the issue before and after when running a program in a shell with unset XDG_DATA_DIRS. I guess I'll leave that up to @lovesegfault to find out. (I tested it with vlc) |
@worldofpeace It fixes issue for me |
It works for myself as well :) |
Ohh, forgot to backport. Will do this. |
@jtojnar @worldofpeace
|
That is actually within gtk. So it isn't related to this exact fix. @jtojnar Could we just hardcode those one's in gtk? |
Yes, that's what I wanted to do, just did not get to it yet. Though, I believe GTK also depends on gsettings-desktop-schemas. |
Fixes #81866
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)