youtube-dl: 2020.03.08 -> 2020.03.24 #83244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zowoq
changed the title
ofborg
bot
requested review from
fpletz,
AndersonTorres,
Enzime,
Phreedom,
bluescreen303 and
Ma27
|
@GrahamcOfBorg build youtube-dl |
|
Very nitpicky, but per the contribution standards the git commit subject and PR title should be https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#submitting-changes |
bhipple
approved these changes
Mar 24, 2020
zowoq
changed the title
|
@nlewo should we backport this? IIRC youtube-dl releases usually contain fixes for several sites that would be broken otherwise on 20.03 :) |
|
Awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/ytdl-org/youtube-dl/releases/tag/2020.03.24
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)