Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.py-multibase: init at 1.0.1 #83276

Merged
merged 1 commit into from Apr 14, 2020
Merged

pythonPackages.py-multibase: init at 1.0.1 #83276

merged 1 commit into from Apr 14, 2020

Conversation

Rakesh4G
Copy link
Contributor

@Rakesh4G Rakesh4G commented Mar 24, 2020 •
edited

Motivation for this change

pythonPackages.py-multibase: init at 1.0.1
DependsOn :: #83275
#83202

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Rakesh4G Rakesh4G mentioned this pull request Mar 24, 2020
Merged
10 tasks
@Rakesh4G Rakesh4G mentioned this pull request Apr 2, 2020
Merged
10 tasks
@CMCDragonkai
Copy link
Member

The py-multihash requires python 3. But are you sure this requires python 3?

@Rakesh4G
Copy link
Contributor Author

Rakesh4G commented Apr 13, 2020 •
edited

The py-multihash requires python 3. But are you sure this requires python 3?

Hi @CMCDragonkai ,

There are test failures in python2.7.
It needs zip_longest which is not available in python2.7
So just to be on safer side, i had disabled this for python2.7

============================= test session starts ==============================
platform linux2 -- Python 2.7.17, pytest-4.6.8, py-1.8.1, pluggy-0.13.1
rootdir: /build/py-multibase-1.0.1
collected 0 items / 1 errors                                                   

==================================== ERRORS ====================================
___________________ ERROR collecting tests/test_multibase.py ___________________
ImportError while importing test module '/build/py-multibase-1.0.1/tests/test_multibase.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
tests/test_multibase.py:9: in <module>
    from multibase import encode, decode, is_encoded
multibase/__init__.py:9: in <module>
    from .multibase import encode, decode, get_codec, is_encoded, Encoding, ENCODINGS  # noqa: F401
multibase/multibase.py:4: in <module>
    from .converters import BaseStringConverter, Base16StringConverter, IdentityConverter, Base64StringConverter, \
multibase/converters.py:3: in <module>
    from itertools import zip_longest
E   ImportError: cannot import name zip_longest
!!!!!!!!!!!!!!!!!!! Interrupted: 1 errors during collection !!!!!!!!!!!!!!!!!!!!
=========================== 1 error in 0.10 seconds ============================
builder for '/nix/store/a8ic252x4d4s113gm04afqj52mi2dkqi-python2.7-py-multibase-1.0.1.drv' failed with exit code 2
error: build of '/nix/store/a8ic252x4d4s113gm04afqj52mi2dkqi-python2.7-py-multibase-1.0.1.drv' failed

@jonringer
Copy link
Contributor

please resolve merge conflict

@Rakesh4G
Copy link
Contributor Author

please resolve merge conflict

Done. Thanks.

jonringer
jonringer approved these changes Apr 14, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 83276 1

2 packages built: - python37Packages.py-multibase - python38Packages.py-multibase

@jonringer jonringer merged commit 90c1406 into NixOS:master Apr 14, 2020
@Rakesh4G Rakesh4G deleted the py-multibase branch April 15, 2020 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Rakesh4G @CMCDragonkai @jonringer