Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying variable font range descriptors in either direction #22416

Merged
merged 1 commit into from Mar 25, 2020

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Mar 24, 2020

Style, stretch and weight descriptor allow specifying ranges for the
variable font that the src: descriptor is referencing. The range
definitions allow both the smaller or larger value to go first and need
to be swapped by the UA.

Keep range value lists in reversed order in the computed style, but swap
them in the FontFace implementation to become meaningful values.This
keeps serialisation intact as specified in the @font - face declaration(
as opposed to reversing the list at the CSS parsing level) and matches
Firefox' behaviour.

Adjust test expectations in at-font-face-descriptors.html for bounds out
of order test cases: expect out of order bounds to be returned in order
as specified. Test case was previously failing in all browsers [1] -
with this change it will pass in Chrome and Firefox. Mark
font-parse-numeric-stretch-style-weight.html test case "500 400 matches
500 400 for weight in @font-face" as passing in Chrome.

[1] https://wpt.fyi/results/css/css-fonts/variations/at-font-face-descriptors.html?label=master&label=experimental&aligned&q=css%2Fcss-fonts%2Fvariations%2F

Fixed: 1063867
Change-Id: I5ae7bc5f3e3a75fa9dce09ca0a66dd083ef29b0b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116447
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#753192}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2116447 branch 4 times, most recently from 1e60ee2 to d2fc3de Compare March 25, 2020 11:18
Style, stretch and weight descriptor allow specifying ranges for the
variable font that the src: descriptor is referencing. The range
definitions allow both the smaller or larger value to go first and need
to be swapped by the UA.

Keep range value lists in reversed order in the computed style, but swap
them in the FontFace implementation to become meaningful values.This
keeps serialisation intact as specified in the @font - face declaration(
as opposed to reversing the list at the CSS parsing level) and matches
Firefox' behaviour.

Adjust test expectations in at-font-face-descriptors.html for bounds out
of order test cases: expect out of order bounds to be returned in order
as specified. Test case was previously failing in all browsers [1] -
with this change it will pass in Chrome and Firefox. Mark
font-parse-numeric-stretch-style-weight.html test case "500 400 matches
500 400 for weight in @font-face" as passing in Chrome.

[1] https://wpt.fyi/results/css/css-fonts/variations/at-font-face-descriptors.html?label=master&label=experimental&aligned&q=css%2Fcss-fonts%2Fvariations%2F

Fixed: 1063867
Change-Id: I5ae7bc5f3e3a75fa9dce09ca0a66dd083ef29b0b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116447
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#753192}
@drott
Copy link
Contributor

drott commented Mar 25, 2020

CC @jfkthame - adjusted those tests accordingly for the inverted range cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants