Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mkl: 2019.5.281 -> 2020.0.166 (Linux only) #83277

Merged
merged 1 commit into from Mar 27, 2020
Merged

mkl: 2019.5.281 -> 2020.0.166 (Linux only) #83277

merged 1 commit into from Mar 27, 2020

Conversation

robertodr
Copy link
Contributor

Motivation for this change

Update MKL to its latest version for Linux

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from bhipple March 24, 2020 11:39
@FRidh
Copy link
Member

FRidh commented Mar 24, 2020

Why linux only?

@FRidh
Copy link
Member

FRidh commented Mar 24, 2020

maybe because of ?

Darwin is pinned to 2019.3 because the DMG does not unpack; see here for details:

@robertodr
Copy link
Contributor Author

maybe because of ?

Darwin is pinned to 2019.3 because the DMG does not unpack; see here for details:

Indeed. The issue linked to in the derivation is still open. I can try to update for Darwin too, but I don't have a way to test it locally.

bhipple
bhipple reviewed Mar 24, 2020
View reviewed changes
Copy link
Contributor

@bhipple bhipple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stites if you get a chance, can you test with the 2020 MKL to see if #75611 is still an issue?

pkgs/development/libraries/science/math/mkl/default.nix Outdated Show resolved Hide resolved
@ofborg ofborg bot requested a review from bhipple March 25, 2020 08:47
bhipple
bhipple approved these changes Mar 27, 2020
View reviewed changes
Copy link
Contributor

@bhipple bhipple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM, can you squash up your commits?

@ofborg ofborg bot requested a review from bhipple March 27, 2020 07:51
@bhipple bhipple merged commit feb39bd into NixOS:master Mar 27, 2020
@bhipple bhipple mentioned this pull request Mar 27, 2020
Merged
@robertodr robertodr deleted the update-mkl branch March 28, 2020 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer matthewbauer approved these changes

@bhipple bhipple bhipple approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@robertodr @FRidh @matthewbauer @bhipple