Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keybase,kbfs,keybase-gui: 5.3.0 -> 5.3.1 #83011

Merged
merged 1 commit into from Mar 24, 2020
Merged

keybase,kbfs,keybase-gui: 5.3.0 -> 5.3.1 #83011

merged 1 commit into from Mar 24, 2020

Conversation

pio2398
Copy link
Contributor

@pio2398 pio2398 commented Mar 20, 2020

Motivation for this change

Update Keybase to 5.3.1. Bug fix release that fix GUI crash for some users keybase/client#23073.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nh2 nh2 mentioned this pull request Mar 24, 2020
Closed
@nh2
Copy link
Contributor

nh2 commented Mar 24, 2020

Expected to fix #82930.

@nh2
Copy link
Contributor

nh2 commented Mar 24, 2020

Merging based on ofborg build and feedback in #82930.

I cannot test the full usage of it on my NixOS machine because I don't have the daemon running from master; NIX_SKIP_KEYBASE_CHECKS=1 keybase-gui starts a quite-blank GUI for me (but already did it for #82740 instead of crashing so that is probably not fully representative).

@nh2 nh2 merged commit d8c1baa into NixOS:master Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@np np Awaiting requested review from np

@puffnfresh puffnfresh Awaiting requested review from puffnfresh

@Br1ght0ne Br1ght0ne Awaiting requested review from Br1ght0ne

@carlsverre carlsverre Awaiting requested review from carlsverre

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pio2398 @nh2