New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify image-loading-subpixel-clip.html. #22403
Conversation
Verified that it still fails with [1] applied and [2] reverted. This may help with deflaking WPT [3] [1] https://chromium-review.googlesource.com/c/chromium/src/+/2111906 [2] https://chromium-review.googlesource.com/c/chromium/src/+/2092698 [3] #22364 TBR:szager@chromium.org Change-Id: Ie668c43c4d03ea442c37075c0e80be5ba1481fff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115932 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by: Stefan Zager <szager@chromium.org> Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#752511}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The review process for this patch is being conducted in the Chromium project.
@chrishtr Looks like this test still times out on Firefox and Chrome. Would you mind taking a second look?
|
Will try to repro now. |
If it helps, I can reproduce on a fresh checkout of WPT via:
Looking at the test - does EDIT: if you want to pass a specific chrome binary in, you can pass the
|
@stephenmcgruer I think you figured it out thanks. I reproduced the flakiness locally and I think |
Glad to hear it. Admin-merging this so that the following patch can be successfully exported. Note that you can check on the stabiltity checks/etc before merging a patch Chromium side. After sending it out for review look for the wpt-pr-bot to comment on it saying its been uploaded to GH (should contain a link to the PR) :). |
Verified that it still fails with [1] applied and [2] reverted.
This may help with deflaking WPT [3]
[1] https://chromium-review.googlesource.com/c/chromium/src/+/2111906
[2] https://chromium-review.googlesource.com/c/chromium/src/+/2092698
[3] #22364
TBR:szager@chromium.org
Change-Id: Ie668c43c4d03ea442c37075c0e80be5ba1481fff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115932
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Stefan Zager <szager@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#752511}