New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/rtorrent: add service #83287
nixos/rtorrent: add service #83287
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have left some feedback I hope you will find useful! Don't hesitate to ask any questions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice looking module, good job 👍 I've never used rtorrent
so I'll leave approval to those more knowledgeable than myself, but I have nothing else to add.
@aanderse I still see your review as requesting changes, did I forget anything ? Anyway thanks for your time and feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry about that! I'm approving in that this looks great to me, but not merging simply because I have never used the program. A review from someone who knows anything about rtorrent
would be appreciated.
As a rtorrent user, this looks good. I recommend a merge |
@iv-nn squash the history and you have a merge 👍 |
136ae95
to
67178eb
Compare
Done. I started writing a test but it's taking a bit longer than I expected, better merge this and I'll create a PR draft with the test soon. |
Motivation for this change
Resuming #30850 using rtorrent new daemon mode rakshasa/rtorrent#446.
Things done
I removed the user part to simplify, I can add it back but it should probably go in home-manager.
I can also add more configurable settings but
extraConfig
should be enough for now.Thanks to @csingley for the work on the original PR.
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)