Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/rtorrent: add service #83287

Merged
merged 1 commit into from May 24, 2020
Merged

Conversation

iv-nn
Copy link
Contributor

@iv-nn iv-nn commented Mar 24, 2020

Motivation for this change

Resuming #30850 using rtorrent new daemon mode rakshasa/rtorrent#446.

Things done

I removed the user part to simplify, I can add it back but it should probably go in home-manager.
I can also add more configurable settings but extraConfig should be enough for now.

Thanks to @csingley for the work on the original PR.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have left some feedback I hope you will find useful! Don't hesitate to ask any questions.

nixos/modules/services/torrent/rtorrent.nix Outdated Show resolved Hide resolved
nixos/modules/misc/ids.nix Outdated Show resolved Hide resolved
nixos/modules/services/torrent/rtorrent.nix Show resolved Hide resolved
nixos/modules/services/torrent/rtorrent.nix Outdated Show resolved Hide resolved
nixos/modules/services/torrent/rtorrent.nix Show resolved Hide resolved
nixos/modules/services/torrent/rtorrent.nix Outdated Show resolved Hide resolved
nixos/modules/services/torrent/rtorrent.nix Show resolved Hide resolved
nixos/modules/services/torrent/rtorrent.nix Outdated Show resolved Hide resolved
@Mic92 Mic92 requested a review from astro March 27, 2020 11:52
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice looking module, good job 👍 I've never used rtorrent so I'll leave approval to those more knowledgeable than myself, but I have nothing else to add.

@flokli flokli requested a review from hax404 March 29, 2020 18:31
@iv-nn iv-nn mentioned this pull request Apr 20, 2020
10 tasks
@iv-nn
Copy link
Contributor Author

iv-nn commented May 2, 2020

@aanderse I still see your review as requesting changes, did I forget anything ? Anyway thanks for your time and feedback.

Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about that! I'm approving in that this looks great to me, but not merging simply because I have never used the program. A review from someone who knows anything about rtorrent would be appreciated.

@pingiun
Copy link
Member

pingiun commented May 3, 2020

As a rtorrent user, this looks good. I recommend a merge

@aanderse
Copy link
Member

aanderse commented May 3, 2020

Thanks @iv-nn and @pingiun 🎉
Full bonus points will be awarded if someone wants to circle back around later and add a nixos test.

@aanderse
Copy link
Member

aanderse commented May 3, 2020

@iv-nn squash the history and you have a merge 👍

@iv-nn
Copy link
Contributor Author

iv-nn commented May 24, 2020

Done. I started writing a test but it's taking a bit longer than I expected, better merge this and I'll create a PR draft with the test soon.

@aanderse
Copy link
Member

As mentioned merging based on review and then testing from @pingiun. Thanks for the contribution @iv-nn it looks great 👍

@aanderse aanderse merged commit a036bae into NixOS:master May 24, 2020
@iv-nn iv-nn deleted the add-rtorrent-service branch May 24, 2020 13:24
@thiagokokada thiagokokada mentioned this pull request Nov 2, 2020
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants