[css-flexbox] Migrate auto-height-with-flex.html to WPT #22404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Mar 23, 2020
Relevant links: - original WK patch and fix: [1] and [2]. - W3 discussion that led to both WK and Blink to diverge from the spec temporarily (until it got fixed) and match other engine's behaviors (eg, Opera, Firefox): [3] [1] https://bugs.webkit.org/show_bug.cgi?id=116107 [2] http://trac.webkit.org/changeset/150087 [3] https://lists.w3.org/Archives/Public/www-style/2013May/0350.html BUG=1063749 R=dgrogan@chromium.org, robertma@chromium.org Change-Id: I3d2a087875402954b5b96ff011208bb869ed3664 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115768 Reviewed-by: Robert Ma <robertma@chromium.org> Reviewed-by: David Grogan <dgrogan@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#752785}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2115768
branch
from
4037d41
to
0e70232
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant links:
from the spec temporarily (until it got fixed) and match other
engine's behaviors (eg, Opera, Firefox): [3]
[1] https://bugs.webkit.org/show_bug.cgi?id=116107
[2] http://trac.webkit.org/changeset/150087
[3] https://lists.w3.org/Archives/Public/www-style/2013May/0350.html
BUG=1063749
R=dgrogan@chromium.org, robertma@chromium.org
Change-Id: I3d2a087875402954b5b96ff011208bb869ed3664
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115768
Reviewed-by: Robert Ma <robertma@chromium.org>
Reviewed-by: David Grogan <dgrogan@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#752785}