kubernetes-helm: 3.1.2 -> 3.1.2 and 2.16.5 split to helm 2 and 3 #83219

dredozubov · 2020-03-23T14:48:06Z

Motivation for this change

Helm 2 and 3 are architecturally different and there are lots of projects still using helm 2. It makes sense to be able to build the last version of Helm 2 as well as Helm 3.

Things done

split kubernetes helm to kubernetes-helm2 and kubernetes-helm3
default kubernetes-helm to kubernetes-helm3 for compatibility

This change is

saschagrunert

Honestly spoken I’m not in favor of having two dedicated packages. But I’m happy to change my opinion if this is really necessary.

dredozubov · 2020-03-23T22:06:19Z

I agree it may look kinda awkward, but helm 2 and 3 are far from compatible and I'd argue that a significant amount of projects have yet to switch to helm 3, so it would be helpful to have the last revision of 2.* beside the primary 3.* for a time being.

Frostman

IMO it makes sense to have helm2 supported in addition to helm3 as helm2 is still looks more popular and many people using it.

pkgs/applications/networking/cluster/helm2/default.nix

saschagrunert

LGTM

dredozubov · 2020-04-09T08:23:09Z

I've rebased the PR against master and updated the helm 2 version to 2.16.5

* split kubernetes helm to kubernetes-helm2 and kubernetes-helm3 * default kubernetes-helm to kubernetes-helm3 for compatibility

dredozubov · 2020-04-13T09:53:37Z

Rebased, all comments addressed.

lsowen · 2020-04-15T20:46:08Z

@dredozubov thank you for taking this on, I for one would really like to have helm2 available, since most of our infrastructure still relies on helm2/tiller.

However, I'm not sure this change will work properly? If you look at the old helm2 build (https://github.com/NixOS/nixpkgs/blob/a038ae1118a676f956c9cf50b78e6e0144c44266/pkgs/applications/networking/cluster/helm/default.nix), it used buildGoPackage, and built tiller and rudder in addition to helm.

dredozubov · 2020-04-16T10:25:28Z

@isowen You're absolutely right. I tried using kubernetes-helm2 yesterday and it's currently broken. I haven't figured out how to properly build it yet, but I plan to work on it when I'll have the time.

infinisil · 2020-08-22T14:07:29Z

Still interested in this? If the conflicts are fixed and the package is confirmed to work I can merge it

saschagrunert

LGTM

teto · 2020-08-28T11:54:26Z

I am new to helm but I've already hit the helm 2/3 schism. The ecosystem warrants to keep both so +1 from me. Could you solve conflicts ?

baracoder · 2020-10-07T12:37:24Z

Ping
I would also be interested in having both version 2 and 3 in nixpkgs

dredozubov · 2020-10-12T07:14:26Z

I've checked this old branch and it's definitely broken for Helm 2. I have neither the knowledge of older golang build tools nor the time to tackle it right now. Is anyone willing to take a shot at this?

teto · 2020-11-09T15:10:14Z

pkgs/applications/networking/cluster/helm2/default.nix

@@ -0,0 +1,33 @@
+{ stdenv, buildGoModule, fetchFromGitHub, installShellFiles, Security }:


Security ? null else it fails on linux

teto · 2020-11-09T15:20:29Z

@dredozubov what kind of error have you encountered ? Maybe we can rebase and merge and fix that afterwards ?
What I've noticed is that the kubernetes 2 doesn't seem to have an init command ? (yet it returns v2.16.5). I dont know much about helm but that seemed fishy.

teto · 2020-11-09T15:58:14Z

pkgs/applications/networking/cluster/helm2/default.nix

+    rev = "v${version}";
+    sha256 = "16hbwmgq14g28r9s0ipnpiqlppyh57yrcqcspmj05vrf9jsg5vwj";
+  };
+  modSha256 = "0618zzi4x37ahsrazsr82anghhfva8yaryzb3p5d737p3ixbiyv8";


this is the same hash as for the v3 version there is something wrong here.

SuperSandro2000 · 2020-11-24T22:07:53Z

pkgs/top-level/all-packages.nix

+  kubernetes-helm = kubernetes-helm3;
+
+  kubernetes-helm2 = callPackage ../applications/networking/cluster/helm2 { };
+
+  kubernetes-helm3 = callPackage ../applications/networking/cluster/helm3 { };


Suggested change

kubernetes-helm = kubernetes-helm3;

kubernetes-helm2 = callPackage ../applications/networking/cluster/helm2 { };

kubernetes-helm3 = callPackage ../applications/networking/cluster/helm3 { };

kubernetes-helm2 = callPackage ../applications/networking/cluster/helm2 { };

kubernetes-helm3 = callPackage ../applications/networking/cluster/helm3 { };

And please move the alias to aliases.nox.

stale · 2021-06-03T20:34:50Z

I marked this as stale due to inactivity. → More info

dredozubov changed the title ~~kubernetes-helm: 3.1.1 -> 3.1.1 and 2.16.3 split to helm 2 and 3~~ kubernetes-helm: 3.1.2 -> 3.1.2 and 2.16.3 split to helm 2 and 3 Mar 23, 2020

ofborg bot added the 8.has: package (new) label Mar 23, 2020

ofborg bot requested review from Frostman, rlupton20, kalbasit, saschagrunert and edude03 March 23, 2020 17:45

ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Mar 23, 2020

saschagrunert reviewed Mar 23, 2020

View reviewed changes

Frostman suggested changes Mar 25, 2020

View reviewed changes

pkgs/applications/networking/cluster/helm2/default.nix Show resolved Hide resolved

pkgs/applications/networking/cluster/helm2/default.nix Outdated Show resolved Hide resolved

saschagrunert approved these changes Apr 1, 2020

View reviewed changes

dredozubov force-pushed the separate-helm-2-and-3 branch from 446fe0d to 24718df Compare April 9, 2020 08:21

dredozubov added 3 commits April 13, 2020 12:52

kubernetes-helm: 3.1.1 -> 3.1.1 and 2.16.3

9b61706

* split kubernetes helm to kubernetes-helm2 and kubernetes-helm3 * default kubernetes-helm to kubernetes-helm3 for compatibility

Fix helm2 Security handling

37fc7c3

Update helm2 version

9adb9f6

dredozubov force-pushed the separate-helm-2-and-3 branch from 24718df to 9adb9f6 Compare April 13, 2020 09:52

dredozubov changed the title ~~kubernetes-helm: 3.1.2 -> 3.1.2 and 2.16.3 split to helm 2 and 3~~ kubernetes-helm: 3.1.2 -> 3.1.2 and 2.16.5 split to helm 2 and 3 Apr 13, 2020

saschagrunert approved these changes Aug 22, 2020

View reviewed changes

ryantm added 2.status: merge conflict and removed 2.status: merge conflict labels Oct 3, 2020

teto reviewed Nov 9, 2020

View reviewed changes

SuperSandro2000 reviewed Nov 24, 2020

View reviewed changes

stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 3, 2021

siraben closed this Jul 27, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

kubernetes-helm: 3.1.2 -> 3.1.2 and 2.16.5 split to helm 2 and 3 #83219

kubernetes-helm: 3.1.2 -> 3.1.2 and 2.16.5 split to helm 2 and 3 #83219

dredozubov commented Mar 23, 2020 •

edited

saschagrunert left a comment

dredozubov commented Mar 23, 2020

Frostman left a comment

saschagrunert left a comment

dredozubov commented Apr 9, 2020

dredozubov commented Apr 13, 2020

lsowen commented Apr 15, 2020

dredozubov commented Apr 16, 2020

infinisil commented Aug 22, 2020

saschagrunert left a comment

teto commented Aug 28, 2020

baracoder commented Oct 7, 2020

dredozubov commented Oct 12, 2020

teto Nov 9, 2020

teto commented Nov 9, 2020

teto Nov 9, 2020

SuperSandro2000 Nov 24, 2020

stale bot commented Jun 3, 2021

		@@ -0,0 +1,33 @@
		{ stdenv, buildGoModule, fetchFromGitHub, installShellFiles, Security }:

kubernetes-helm: 3.1.2 -> 3.1.2 and 2.16.5 split to helm 2 and 3 #83219

kubernetes-helm: 3.1.2 -> 3.1.2 and 2.16.5 split to helm 2 and 3 #83219

Conversation

dredozubov commented Mar 23, 2020 • edited

Motivation for this change

Things done

saschagrunert left a comment

Choose a reason for hiding this comment

dredozubov commented Mar 23, 2020

Frostman left a comment

Choose a reason for hiding this comment

saschagrunert left a comment

Choose a reason for hiding this comment

dredozubov commented Apr 9, 2020

dredozubov commented Apr 13, 2020

lsowen commented Apr 15, 2020

dredozubov commented Apr 16, 2020

infinisil commented Aug 22, 2020

saschagrunert left a comment

Choose a reason for hiding this comment

teto commented Aug 28, 2020

baracoder commented Oct 7, 2020

dredozubov commented Oct 12, 2020

teto Nov 9, 2020

Choose a reason for hiding this comment

teto commented Nov 9, 2020

teto Nov 9, 2020

Choose a reason for hiding this comment

SuperSandro2000 Nov 24, 2020

Choose a reason for hiding this comment

stale bot commented Jun 3, 2021

dredozubov commented Mar 23, 2020 •

edited