Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Unskip linting unit test by making it work with python3" #22413

Merged
merged 2 commits into from Mar 24, 2020

Conversation

Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented Mar 24, 2020

Reverts #21954

The print function is already tested in the test_print_function test below. As long as we support Python 2, we should also have the test_print_statement test for print statements.

This reverts commit b9b3e97.
Copy link
Contributor

@stephenmcgruer stephenmcgruer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yikes, thanks for catching this!

There are Azure failures which I'll check now.

@stephenmcgruer
Copy link
Contributor

Azure failure seems to be Python 3.8 on manifest/tests/test_manifest.py, which this PR doesn't touch (cc @svillar - are you aware of that failure?).

Admin merging this PR.

@stephenmcgruer stephenmcgruer merged commit a1e3c1e into master Mar 24, 2020
@stephenmcgruer stephenmcgruer deleted the revert-21954-test_file_lints branch March 24, 2020 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants