[Gecko Bug 1623476] Fix event targeting in a click_events_on_input.html. #22407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Presumably, the intention of the test is to hit the middle of the target. To this end, the test specifies an offset of half the target's dimensions relative to the origin of the target. However, when pointerMove() is given an element as origin, it already uses the element's center as the origin point, so we end up actually targeting the bottom right pixel which is prone to rounding issues. Differential Revision: https://phabricator.services.mozilla.com/D67518 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1623476 gecko-commit: 0cd57f00ac5d1aada0c5ae8374c5a25ea543332d gecko-integration-branch: autoland gecko-reviewers: jgraham
wpt-pr-bot
approved these changes
Mar 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Presumably, the intention of the test is to hit the middle of the target. To
this end, the test specifies an offset of half the target's dimensions
relative to the origin of the target.
However, when pointerMove() is given an element as origin, it already uses
the element's center as the origin point, so we end up actually targeting
the bottom right pixel which is prone to rounding issues.
Differential Revision: https://phabricator.services.mozilla.com/D67518
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1623476
gecko-commit: 0cd57f00ac5d1aada0c5ae8374c5a25ea543332d
gecko-integration-branch: autoland
gecko-reviewers: jgraham