Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vtkWithQt4: actually build QVTK libs/headers #84772

Merged
merged 1 commit into from Apr 29, 2020
Merged

vtkWithQt4: actually build QVTK libs/headers #84772

merged 1 commit into from Apr 29, 2020

Conversation

bcdarwin
Copy link
Member

@bcdarwin bcdarwin commented Apr 9, 2020 •
edited

Motivation for this change
  • VTK_USE_QT is obsolete and didn't have the intended effect. (For instance, you may verify that QVTKWidgets.h is now present in the output, unlike previously.)

cc @knedlsepp @veprbl

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • [NA] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from knedlsepp April 9, 2020 04:22
@bcdarwin
vtkWithQt4: actually build QVTK libs/headers
2924e78 
- VTK_USE_QT is obsolete and didn't have the intended effect
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/148

@veprbl
Copy link
Member

veprbl commented Apr 27, 2020

@GrahamcOfBorg build vtkWithQt4 vtkWithQt4.passthru.tests

@bcdarwin
Copy link
Member Author

bcdarwin commented Apr 28, 2020 •
edited

The Darwin build hasn't run yet but Qt4 doesn't evaluate on Darwin anyway.

@veprbl veprbl merged commit 948b383 into NixOS:master Apr 29, 2020
@bcdarwin bcdarwin deleted the fix-qvtk branch April 29, 2020 23:12
@bcdarwin bcdarwin mentioned this pull request Aug 9, 2020
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl approved these changes

@knedlsepp knedlsepp Awaiting requested review from knedlsepp

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bcdarwin @nixos-discourse @veprbl