{checkout,clone}: redirect output to /dev/null #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grahamc
reviewed
Apr 9, 2020
It fills the logs with typically-useless information. We don't really care about the novels people write in their commit messages. The only `git` commands that were left unmodified are the ones where we use their output in some way (and thus, it isn't printed to stdout/err anyways).
cole-h
commented
Apr 9, 2020
The `id` field is not the GitHub PR or issue number; the `number` field is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It fills the logs with typically-useless information. We don't really
care about the novels people write in their commit messages.
The only
gitcommands that were left unmodified are the ones where weuse their output in some way (and thus, it isn't printed to stdout/err
anyways).
There is a chance that this discards actual error information. However, in the past... checks calendar 4 days I've been a log-watcher, I've only seen innocuous output from
gitthat might be useful or interesting if it was in an interactive session and not just a byproduct of our various checks.