Skip to content

vocal: add missing glib-networking #84728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 8, 2020
Merged

vocal: add missing glib-networking #84728

merged 1 commit into from
Apr 8, 2020
+2 −0

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Apr 8, 2020 •
edited
Loading

otherwise https is disabled

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@Mic92
vocal: add missing glib-networking

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
cbf0e05 
otherwise https is disabled
@Mic92 Mic92 requested a review from worldofpeace April 8, 2020 15:37
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Apr 8, 2020
@worldofpeace worldofpeace merged this pull request into NixOS:vocal Apr 8, 2020
@worldofpeace
Copy link
Contributor

merged to master in b9b8388
. It seems a branch was created vocal in nixpkgs itself. Will delete that.

@worldofpeace
Copy link
Contributor

backported to 20.03 4ca1372
backported to 19.09 77b9000

@Mic92 Mic92 deleted the vocal branch April 8, 2020 18:47
@Mic92
Copy link
Member Author

Mic92 commented Apr 8, 2020

mhm. I think I used hub to create the PR.

@worldofpeace
Copy link
Contributor

I believe if you don't push the branch before hub pr it will default try to make the branch in nixpkgs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mic92 @worldofpeace