Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

olive-editor 0.1.1 -> 0.1.2 #84727

Merged
merged 1 commit into from Apr 9, 2020
Merged

olive-editor 0.1.1 -> 0.1.2 #84727

merged 1 commit into from Apr 9, 2020

Conversation

raboof
Copy link
Member

@raboof raboof commented Apr 8, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @balsoft @luzpaz

@ofborg ofborg bot requested a review from balsoft April 8, 2020 15:32
Emantor
Emantor approved these changes Apr 8, 2020
View reviewed changes
Copy link
Member

@Emantor Emantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • built on NixOS unstable
$ nix build --no-link --keep-going --option build-use-sandbox relaxed -f /home/phoenix/.cache/nixpkgs-review/pr-84727/build.nix
[3 built, 26 copied (237.8 MiB), 44.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/84727
1 package built:
olive-editor
  • tested binary with a video file, import and playback worked.

@luzpaz
Copy link
Contributor

luzpaz commented Apr 8, 2020

nice!

@aanderse
Copy link
Member

aanderse commented Apr 9, 2020

@GrahamcOfBorg build olive-editor

@aanderse aanderse merged commit 0d62914 into NixOS:master Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Emantor Emantor Emantor approved these changes

@balsoft balsoft Awaiting requested review from balsoft

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@raboof @luzpaz @aanderse @Emantor