Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mlkit: init at 4.5.0 #84730

Merged
merged 1 commit into from Jun 23, 2020
Merged

mlkit: init at 4.5.0 #84730

merged 1 commit into from Jun 23, 2020

Conversation

athas
Copy link
Contributor

@athas athas commented Apr 8, 2020

Motivation for this change

I don't think Nixpkgs contains quite enough Standard ML compilers. Here's one more. It's actively maintained and in use.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

FRidh
FRidh requested changes Apr 8, 2020
View reviewed changes
pkgs/development/compilers/mlkit/default.nix Outdated Show resolved Hide resolved
pkgs/development/compilers/mlkit/default.nix Outdated Show resolved Hide resolved
pkgs/development/compilers/mlkit/default.nix Outdated Show resolved Hide resolved
pkgs/development/compilers/mlkit/default.nix Outdated Show resolved Hide resolved
@athas
Copy link
Contributor Author

athas commented Apr 8, 2020

Thanks for the prompt review! Replacing the buildPhase with makeFlags unfortunately doesn't work, likely because the Makefile has imperfect dependencies. make mlkit must finish completely before running make mlkib_libs.

@athas athas requested a review from FRidh April 8, 2020 20:25
@athas athas changed the title mlkit: init at 4.4.3 mlkit: init at 4.5.0 Apr 30, 2020
@athas
Copy link
Contributor Author

athas commented Apr 30, 2020

I have updated the derivation to use the just released mlkit 4.5.0, and also simplified the handling of autoconf.

@athas
Copy link
Contributor Author

athas commented Jun 21, 2020

I quoted the homepage URL, as I was told that unquoted URLs are now deprecated.

danieldk
danieldk approved these changes Jun 23, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Result of nixpkgs-review pr 84730 1

1 package built:
- mlkit 
$ mlkit --version
MLKit  (2020-06-23T-07:29:35) [X64 Backend]
 mlkit life.sml 
[wrote X64 code file:	MLB/RI_GC/base-link_objects.s]
[wrote executable file:	run]

@danieldk danieldk merged commit 28d2854 into NixOS:master Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk approved these changes

@multun multun multun approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@athas @danieldk @FRidh @multun