Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: mobile-nixos/mobile-nixos
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0508ffb5065b
Choose a base ref
...
head repository: mobile-nixos/mobile-nixos
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 7eae7aed8831
Choose a head ref
  • 3 commits
  • 2 files changed
  • 1 contributor

Commits on Apr 8, 2020

  1. ci: Add assertion that validates evaluations are differents 

    See the following commit
    @samueldr
    samueldr committed Apr 8, 2020
    Copy the full SHA
    73b7af1 View commit details

  2. default.nix: Pass additional config to evalWith 

    This broke eval for aarch64-linux platforms.

See the previous commit for an assertion that should prevent such
breakage from going through in the future.
    @samueldr
    samueldr committed Apr 8, 2020
    Copy the full SHA
    245ecce View commit details

  3. Merge pull request #125 from samueldr-wip/fix/eval-failure 

    Fix evaluation failure where aarch64-linux outputs are accidentally x86_64-linux
    @samueldr
    samueldr authored Apr 8, 2020

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    7eae7ae View commit details
Showing with 4 additions and 0 deletions.
  1. +3 −0 .ci/instantiate-all.nix
  2. +1 −0 default.nix
3 changes: 3 additions & 0 deletions .ci/instantiate-all.nix
View file
Original file line number Diff line number Diff line change
@@ -44,6 +44,9 @@ let
;

flattened =
# If this fails, evaluations probably don't receive additional configuration
# configuring nixpkgs.localSystem.
assert devices."device.asus-z00t.aarch64-linux" != devices."device.asus-z00t.x86_64-linux";
release //
devices //
# We could try and do something smart to unwrap two levels of attrsets
1 change: 1 addition & 0 deletions default.nix
View file
Original file line number Diff line number Diff line change
@@ -46,6 +46,7 @@ let
eval = evalWith {
device = final_device;
modules = configuration;
inherit additionalConfiguration;
};

# This is used by the `-A installer` shortcut.