Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[staging] Revert "perlPackages.XMLParser: 2.46 -> 2.44" #84683

Merged
merged 1 commit into from Apr 8, 2020
Merged

[staging] Revert "perlPackages.XMLParser: 2.46 -> 2.44" #84683

merged 1 commit into from Apr 8, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Apr 8, 2020 •
edited

Motivation for this change

#75132 was meant for 2.46, but 2.44 was merged into staging.

The result is that the patch fails to apply and immediately breaks perlPackages.XMLParser

This reverts commit ca04f87.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build perlPackages.XMLParser

@Ericson2314
Copy link
Member

Thanks!

@jonringer jonringer merged commit 37be0ab into NixOS:staging Apr 8, 2020
@jonringer jonringer deleted the fix-perl branch April 8, 2020 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samueldr samueldr Awaiting requested review from samueldr

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 1001-2500 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @Ericson2314