Unbreak tensorflow haskell 1 #84720
Merged
Unbreak tensorflow haskell 1 #84720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the first step towards unbreaking the tensorflow packages.
ofborg
bot
added
8.has: package (new)
10.rebuild-darwin: 501+
10.rebuild-darwin: 1001-2500
10.rebuild-linux: 501+
10.rebuild-linux: 1001-2500
10.rebuild-darwin: 0
10.rebuild-linux: 0
and removed
10.rebuild-darwin: 501+
10.rebuild-darwin: 1001-2500
10.rebuild-linux: 501+
10.rebuild-linux: 1001-2500
labels
cdepillabout
approved these changes
Apr 9, 2020
There was a problem hiding this comment.
LGTM.
I'll continue to merge these PRs for you, but I'm worried about two things:
- The upstream tensorflow-haskell repo looks somewhat dead. There seem to be a bunch of useful PRs sitting around that no one is merging. There doesn't appear to be anyone working on updating tensorflow-haskell for tensorflow-1.15.
- I guess eventually nixpkgs will drop support for tensorflow-1? And at that point, tensorflow-haskell just won't be able to be compiled, unless it gets support for tensorflow-2?
If upstream doesn't merge your PRs in a timely manner, maybe you should just fork tensorflow-haskell? Maybe you'd be able to find a community of people willing to work on it?
Alternatively, I think there is already a good community around hasktorch, if you'd be interested in using that instead.
|
Good points all. At the moment though, we're actively using it and I can take over maintenance for the next couple of months. (And I'm working on getting it going with Tensorflow 1.15.) If and when it dies, that'll be fine. But that's not yet. |
|
BTW, thanks for merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
haskellPackages.tensorflow is currently badly broken. I have things working, and will submit the associated pull requests successively. First, I need updates to the various dependencies - this is this pull request.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)