Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

arcanist: bring back php with curl and json #84674

Closed
wants to merge 1 commit into from
Closed

arcanist: bring back php with curl and json #84674

wants to merge 1 commit into from

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Apr 7, 2020 •
edited

arcanist needs this these two extensions to work.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@flokli
arcanist: bring back php with curl and json
cf31d9b 
arcanist needs this these two extensions to work.
@flokli flokli requested a review from lovesegfault April 7, 2020 22:30
@ofborg ofborg bot requested a review from thoughtpolice April 7, 2020 22:37
@flokli
Copy link
Contributor Author

flokli commented Apr 7, 2020

Apparently, php should already be a php containing the default packages, but patchShebangs picks the wrong php for some reason.

@flokli
Copy link
Contributor Author

flokli commented Apr 7, 2020

I added a comment in https://github.com/NixOS/nixpkgs/pull/83896/files#r405156130.

@flokli flokli closed this Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lovesegfault lovesegfault Awaiting requested review from lovesegfault

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@flokli