This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/please-fix-all-packages-which-were-broken-by-the-qt-wrapping-changes/6444/28

@das-g thank you for your attention! I've dropped stdenv from the arguments - looks better to me, not sure what's the right thing here, if there is such thing.

The part around here in the manual should be useful to you https://nixos.org/nixpkgs/manual/#qt-default-nix-co-3

@worldofpeace good point! In all three cases the hook ended up wrapping the .foo-wrapped binary so things worked out somewhat fine. Nevertheless having multiple levels of wrappers is ugly so I added dontWrapQtApps = true;, changed the wrapping function to the qt one and removed makeWrapper from nativeBuildInputs since it was no longer needed.

bomi remains broken though, as documented in #57532

But there's no way I could even test this manually. Perhaps our other reviewer did this.

Me? I didn't test anything, I only looked at the diff and commit messages. I could run nixpkgs-review pr if that helps, but I guess whether stuff builds can also be tested by @GrahamcOfBorg, can't it?

The functionality of the build results I can't really test either, as I don't know the packaged applications. Maybe ping the respective package maintainers?

I still think Qt's mkDerivation does more harm than good and should not have been introduced. Adding the dependencies (and wrapQtAppsHook for programs) should be sufficient. (There is also one minor improvement in debug flag handling but it does not outweigh the loss of compositionality. We should finish #71089 to get the debug flag handling to other qt setup hooks.)

@jtojnar I personally don't see much benefit in telling people to commit to something that isn't a committed practice, when it's mentioned in detail in our official documentation.
For what it's worth, I think any user of these commits would appreciate them committed right away.

@mmilata Can you rebase?

@worldofpeace rebased

I've backported this to 20.03, but I've yet to do it for 19.09 because there's conflicts.

Did the 19.09 in #85805 - gonna try building it now.

Just to have it on the record, copying my rant from IRC:

the fact that qt's mkDerivation should be removed was acknowledged by Thomas
since it does not bring almost any benefits compared to wrapQtAppsHook I see no reason to continue using it, especially if it is to be deprecated
the fact that documentation promotes it is unfortunate but it is a documentation bug that can be rectified

but since you already did the work and we do not want to make you redo it, I agreed with merging this for now:

I guess we can merge it now and then do a removing sprint

Yep, thank you so much @mmilata for taking initiative to get these last fixes, I know people will appreciate it.

No need to merge this just to not upset me, I'm not too invested, just wanted to see if it's possible to fix some of the broken packages using a simple script:)

Anyway, #85805 built for me - had to drop bibletime and write_stylus since they'd require backporting more commits which is probably out of scope. Also luckybackup was added after 19.09 was forked and according to git log it probably never worked??