Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tixati: 2.67 -> 2.72 #84756

Closed
wants to merge 0 commits into from
Closed

tixati: 2.67 -> 2.72 #84756

wants to merge 0 commits into from

Conversation

bcc32
Copy link
Contributor

@bcc32 bcc32 commented Apr 8, 2020 •
edited

Motivation for this change

Upgrading tixati to version 2.72

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Package closure size increased from 166689224 to 167160088 (+0.28%).

@ofborg ofborg bot requested a review from volth April 8, 2020 23:40
evils
evils approved these changes Apr 8, 2020
View reviewed changes
Copy link
Member

@evils evils left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks
i'm kinda surprised @r-ryantm (bot) hasn't updated this yet

@ryantm
Copy link
Member

ryantm commented Apr 9, 2020

the bot doesn't make new PRs if one is already open: #81639

@bcc32 bcc32 closed this Apr 22, 2020
@evils
Copy link
Member

evils commented Apr 22, 2020

@bcc32 did you mean to close this PR?

@bcc32
Copy link
Contributor Author

bcc32 commented Apr 22, 2020

Oh no! I didn't mean to do that, I meant to rename the branch, but it looks like GitHub PRs don't support that. I'll open a new PR with the same contents. (No option to reopen on my end.)

@bcc32 bcc32 mentioned this pull request Apr 22, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evils evils evils approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bcc32 @ryantm @evils @Janik-Haag