Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nginx-sso: 0.24.0 -> 0.24.1 #84699

Merged
merged 1 commit into from Apr 9, 2020
Merged

nginx-sso: 0.24.0 -> 0.24.1 #84699

merged 1 commit into from Apr 9, 2020

Conversation

nyanloutre
Copy link
Member

Motivation for this change

Security fix with the cookie generation

Should be cherry-picked in 20.03

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from delroth April 8, 2020 09:09
@aanderse aanderse merged commit 19ac4ae into NixOS:master Apr 9, 2020
@aanderse
Copy link
Member

aanderse commented Apr 9, 2020

@nyanloutre please file backport PR if able. Thank you!

@nyanloutre nyanloutre mentioned this pull request Apr 10, 2020
Merged
10 tasks
@nyanloutre
Copy link
Member Author

I opened #84948

@nyanloutre nyanloutre deleted the nginx-sso_0_24_1 branch September 9, 2020 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delroth delroth delroth approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nyanloutre @aanderse @delroth