Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

youtube-viewer: 3.3.0 -> 3.7.5 #84723

Merged
merged 1 commit into from Apr 8, 2020
Merged

Conversation

AleXoundOS
Copy link
Contributor

Motivation for this change

Recently YouTube API Services team has disabled youtube-viewer API key (they reduced quota limit of queries per day for a single API key). youtube-viewer repository has been updated to allow setting your personally obtained API key.
So, for now, without updating youtube-viewer you're not able to view YouTube videos with it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell --pure -I nixpkgs=https://github.com/alexoundos/nixpkgs/archive/52ad14bbee1c44688acdffc6a3ac595b80adca15.tar.gz -p youtube-viewer --run "youtube-viewer"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

test the functionality in NixOS

  1. Temporarily set the API key (please, do not overuse my).
    $ cp api.txt ~/.config/youtube-viewer/api.json

  2. Run.

$ export NIX_SSL_CERT_FILE=/etc/ssl/certs/ca-bundle.crt
$ nix-shell --pure -I nixpkgs=https://github.com/alexoundos/nixpkgs/archive/52ad14bbee1c44688acdffc6a3ac595b80adca15.tar.gz --keep NIX_SSL_CERT_FILE -p youtube-viewer --run "youtube-viewer starcraft remastered"

SSL certificate trick is mandatory for pure nix-shell and partially described in #13744 (comment).

Copy link
Member

@Emantor Emantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per rfc45, the homepage should be quoted: homepage = "https://github.com/trizen/youtube-viewer";

@Ma27 Ma27 merged commit f6f46e1 into NixOS:master Apr 8, 2020
@woffs woffs mentioned this pull request May 15, 2020
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants