Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linuxPackages.nvidia_x11: 440.64 -> 440.82 #84680

Merged
merged 1 commit into from Apr 9, 2020
Merged

linuxPackages.nvidia_x11: 440.64 -> 440.82 #84680

merged 1 commit into from Apr 9, 2020

Conversation

lovesegfault
Copy link
Member

Motivation for this change

Noticed it was all of date, also this gets rid of all the patches we were using to support the 5.6 kernel.

WIP because persistenced and settings are still not on the newer version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@eadwu
Copy link
Member

eadwu commented Apr 8, 2020

I really hate how NVIDIA doesn't keep anything in sync. Sometimes the link from download.nvidia.com doesn't work while it's on Github while other times it's the opposite. Like right now, the links changed from work [1].

[1] 0f9672d#diff-6e753e21cbb5d3dac4390d93a4d2ea12L10

eadwu
eadwu approved these changes Apr 9, 2020
View reviewed changes
Copy link
Member

@eadwu eadwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified hashes and builds fine on 5.4.31.

@lovesegfault lovesegfault marked this pull request as ready for review April 9, 2020 03:01
@lovesegfault
Copy link
Member Author

@baracoder, @emilazy ready to go :)

@emilazy
Copy link
Member

emilazy commented Apr 9, 2020

Sorry, I don't have an NVIDIA card or I'd test this :)

@veprbl veprbl merged commit 98790da into NixOS:master Apr 9, 2020
veprbl pushed a commit that referenced this pull request Apr 9, 2020
@lovesegfault @veprbl
linuxPackages.nvidia_x11: 440.64 -> 440.82
f56a3e1 
(cherry picked from commit 73ff54e)
cc #84680
@veprbl veprbl added the 8.has: port to stable A PR already has a backport to the stable release. label Apr 9, 2020
stigok pushed a commit to stigok/nixpkgs that referenced this pull request Jun 12, 2020
@lovesegfault @stigok
linuxPackages.nvidia_x11: 440.64 -> 440.82
523f33a 
(cherry picked from commit 73ff54e)
cc NixOS#84680
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eadwu eadwu eadwu approved these changes

@baracoder baracoder Awaiting requested review from baracoder

@emilazy emilazy Awaiting requested review from emilazy

Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lovesegfault @eadwu @emilazy @veprbl