Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

page: init at 2.3.4 #82949

Merged
merged 2 commits into from Apr 8, 2020
Merged

page: init at 2.3.4 #82949

merged 2 commits into from Apr 8, 2020

Conversation

s1341
Copy link
Contributor

@s1341 s1341 commented Mar 19, 2020

Motivation for this change

Add the page utility, which is a pager using nvim's :terminal feature.

See #82948 82948

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@s1341 s1341 mentioned this pull request Mar 19, 2020
Closed
@s1341 s1341 changed the title page: init @ v2.3.2 page: init at v2.3.2 Mar 19, 2020
@s1341 s1341 force-pushed the master branch 3 times, most recently from ced855f to 7d7afb7 Compare March 19, 2020 18:02
symphorien
symphorien reviewed Mar 19, 2020
View reviewed changes
Copy link
Member

@symphorien symphorien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to add page to pkgs/top-level/all-packages.nix.

pkgs/tools/misc/page/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/page/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/page/default.nix Outdated Show resolved Hide resolved
@s1341
Copy link
Contributor Author

s1341 commented Mar 19, 2020

@symphorien thanks for the review. Pushed the changes.

@s1341 s1341 changed the title page: init at v2.3.2 page: init at 2.3.2 Mar 19, 2020
@symphorien
Copy link
Member

When running

echo test | LANG=C page

I get a spurious message:

/nix/store/kp60cyq5iig35gzp7l2pr0ilxxa4m919-bash-interactive-4.4-p23/bin/bash: warning: here-document at line 0 delimited by end-of-file (wanted `EOF')

@s1341
Copy link
Contributor Author

s1341 commented Mar 20, 2020

When running

echo test | LANG=C page

I get a spurious message:

/nix/store/kp60cyq5iig35gzp7l2pr0ilxxa4m919-bash-interactive-4.4-p23/bin/bash: warning: here-document at line 0 delimited by end-of-file (wanted `EOF')

I don't get that error from either bash or zsh...

@symphorien
Copy link
Member

I still get it with your latest commit, in the shell given by nix-review.

@s1341
Copy link
Contributor Author

s1341 commented Mar 20, 2020

@symphorien can you give me the full command to execute that shell?

@symphorien
Copy link
Member

nix-review pr 82949

@s1341
Copy link
Contributor Author

s1341 commented Mar 22, 2020

I see the issue... Not sure what is causing it...

@I60R
Copy link

I60R commented Mar 22, 2020

This message appears when $SHELL is set to /bin/bash and then :term tail -f <<EOF is executed in neovim by page.

I'm able to reproduce it with /bin/bash -c "tail -f <<EOF".

There's probably some bug on bash side and they should fix it. However, it shouldn't be blocker for us, since I simply need to find a way to create empty :term buffer even without spawning bash.

@symphorien
Copy link
Member

Only /bin/sh exists on NixOS (it is more or less guaranteed by posix).

@I60R
Copy link

I60R commented Mar 22, 2020

Ok, this should be fixed in the latest version

@s1341 s1341 changed the title page: init at 2.3.2 page: init at 2.3.4 Mar 22, 2020
@s1341
Copy link
Contributor Author

s1341 commented Mar 22, 2020

@symphorien, @I60R has fixed the issue you reported. I've bumped this up to 2.3.4 which includes the fix.

@s1341 s1341 mentioned this pull request Mar 31, 2020
Closed
10 tasks
jonringer
jonringer approved these changes Apr 8, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
shows usage

https://github.com/NixOS/nixpkgs/pull/82949
1 package built:
page

[nix-shell:/home/jon/.cache/nixpkgs-review/pr-82949]$ tree ./results/page
./results/page
├── bin
│   └── page
└── share
    ├── bash-completion
    │   └── completions
    │       └── page.bash
    ├── fish
    │   └── vendor_completions.d
    │       └── page.fish
    └── zsh
        └── site-functions
            └── _page

8 directories, 4 files

@jonringer
Copy link
Contributor

@GrahamcOfBorg build page

@jonringer jonringer merged commit f1090bd into NixOS:master Apr 8, 2020
@s1341
Copy link
Contributor Author

s1341 commented Apr 12, 2020

thanks @jonringer!

@pyrox0 pyrox0 mentioned this pull request Mar 27, 2022
Closed
@I60R
Copy link

I60R commented Dec 8, 2022

Hey @s1341

page recently got 4.4.0 version, but nixpkgs displays outdated 3.1.2.

Could I ask you to bump the version?

Also, there's another binary included called nv which is a replacement for neovim-remote, would you like to add it to package?

@s1341
Copy link
Contributor Author

s1341 commented Dec 12, 2022

@I60R see #205528

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk left review comments

@jonringer jonringer jonringer approved these changes

@symphorien symphorien symphorien approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@s1341 @symphorien @I60R @jonringer @danieldk @Janik-Haag