Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cawbird: 1.0.4 -> 1.0.5 #84745

Merged
merged 1 commit into from Apr 8, 2020
Merged

cawbird: 1.0.4 -> 1.0.5 #84745

merged 1 commit into from Apr 8, 2020

Conversation

schmittlauch
Copy link
Member

Motivation for this change

just a simple version bump, no major changes

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@schmittlauch
Copy link
Member Author

@GrahamcOfBorg build cawbird

@ofborg ofborg bot requested a review from jonafato April 8, 2020 19:31
jonafato
jonafato approved these changes Apr 8, 2020
View reviewed changes
Copy link
Contributor

@jonafato jonafato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • built on NixOS
  • tested basic help messages of all binaries
  • leaf package
  • checked OfBorg all green

@CloudArtAdmins
Copy link
Contributor

CloudArtAdmins commented Apr 8, 2020 •
edited

  • built on NixOS
  • tested basic help messages of all binaries
  • checked OfBorg all green

@worldofpeace worldofpeace merged commit f49114b into NixOS:master Apr 8, 2020
@worldofpeace
Copy link
Contributor

Thanks for reviews.

@schmittlauch schmittlauch mentioned this pull request Apr 10, 2020
Merged
10 tasks
@schmittlauch
Copy link
Member Author

backport: #84891

@schmittlauch
Copy link
Member Author

I guess I skip the backport to 19.09, as it'll be EOL quite soon and the update doesn't seem to include any important security fixes.

@worldofpeace
Copy link
Contributor

I guess I skip the backport to 19.09, as it'll be EOL quite soon and the update doesn't seem to include any important security fixes.

Yeah, bugfixes and security updates for 19.09 should still be done. But this is really minor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonafato jonafato jonafato approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@schmittlauch @CloudArtAdmins @worldofpeace @jonafato