Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnome3.gnome-color-manager: 3.32.0 -> 3.36.0 #84734

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

gnome3.gnome-color-manager: 3.32.0 -> 3.36.0 #84734

wants to merge 1 commit into from

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Apr 8, 2020

Motivation for this change

It removes calibration but rest of GNOME is not ready for it yet:

https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/951

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jtojnar jtojnar mentioned this pull request Apr 8, 2020
Merged
10 tasks
@ofborg ofborg bot added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Apr 8, 2020
@ofborg ofborg bot requested review from hedning and worldofpeace April 8, 2020 16:28
@jtojnar jtojnar added this to To Do in GNOME Apr 9, 2020
This was referenced Sep 2, 2020
Closed
Closed
This was referenced Nov 28, 2020
Closed
Closed
@ryantm ryantm changed the title gnome3.gnome-color-management: 3.32.0 → 3.36.0 gnome3.gnome-color-manager: 3.32.0 → 3.36.0 Dec 2, 2020
@jtojnar jtojnar changed the title gnome3.gnome-color-manager: 3.32.0 → 3.36.0 gnome3.gnome-color-manager: 3.32.0 -> 3.36.0 Dec 2, 2020
@jtojnar jtojnar mentioned this pull request Dec 5, 2020
Closed
@dasj19
Copy link
Contributor

dasj19 commented May 18, 2021

Why isn't this being merged?

@jtojnar
Copy link
Contributor Author

jtojnar commented May 18, 2021

See the OP, gnome-control-center requires a program that is removed newer versions of g-c-m.

@bobby285271 bobby285271 mentioned this pull request Aug 14, 2021
Closed
@jtojnar jtojnar mentioned this pull request Sep 11, 2021
Draft
@stale
Copy link

stale bot commented Nov 16, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Nov 16, 2021
@bobby285271
Copy link
Member

This is updated in 133d326, but maybe we still need the cleanups here 👀

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 29, 2022
@bobby285271
Copy link
Member

Emmm... Is the gnome-control-center issue resolved? https://gitlab.gnome.org/GNOME/gnome-control-center/-/blob/42.0/panels/color/cc-color-panel.c#L637

@jtojnar
Copy link
Contributor Author

jtojnar commented Mar 29, 2022

Ugh, I thought I removed the commit from the GNOME 42 PR. Reverted in 9a2de8c.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 1, 2022
@bobby285271 bobby285271 mentioned this pull request Nov 5, 2022
Merged
13 tasks
@wegank wegank mentioned this pull request Aug 7, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hedning hedning Awaiting requested review from hedning

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

Assignees
No one assigned
Labels
2.status: merge conflict 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
GNOME
  
To Do
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jtojnar @dasj19 @bobby285271 @SuperSandro2000