Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/gnome-remote-desktop: enable pipewire #84675

Merged
merged 1 commit into from Apr 8, 2020
Merged

nixos/gnome-remote-desktop: enable pipewire #84675

merged 1 commit into from Apr 8, 2020

Conversation

worldofpeace
Copy link
Contributor

We need the pipewire service to actually use this.
Tested with g-c-c Sharing.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
nixos/gnome-remote-desktop: enable pipewire
d8d51e7 
We need the pipewire service to actually use this.
Tested with g-c-c Sharing.
@jtojnar jtojnar merged commit 94eb65a into NixOS:master Apr 8, 2020
@jtojnar jtojnar deleted the gnome-pipewire branch April 8, 2020 08:18
@worldofpeace
Copy link
Contributor Author

Will backport this since it's probably broken on stable.

@worldofpeace worldofpeace added the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 8, 2020
@worldofpeace worldofpeace self-assigned this Apr 8, 2020
@worldofpeace
Copy link
Contributor Author

backported in c264873

@worldofpeace worldofpeace added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Apr 10, 2020
@worldofpeace worldofpeace removed their assignment Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hedning hedning hedning approved these changes

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nixos 8.has: module (update) 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@worldofpeace @hedning @jtojnar