[19.09] chromium: 80.0.3987.163 -> 81.0.4044.92 (backport) #84709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can e.g. save around 150k lines of unnecessary log messages which take up around 66% of the total lines (based on a log of 80.0.3987.100): 29527 warning: unknown warning option '-Wno-bitwise-conditional-parentheses'; did you mean '-Wno-bitwise-op-parentheses'? [-Wunknown-warning-option] 29527 warning: unknown warning option '-Wno-builtin-assume-aligned-alignment' [-Wunknown-warning-option] 29527 warning: unknown warning option '-Wno-deprecated-copy'; did you mean '-Wno-deprecated'? [-Wunknown-warning-option] 29527 warning: unknown warning option '-Wno-final-dtor-non-final-class'; did you mean '-Wno-abstract-final-class'? [-Wunknown-warning-option] 29527 warning: unknown warning option '-Wno-implicit-int-float-conversion'; did you mean '-Wno-implicit-float-conversion'? [-Wunknown-warning-option] (cherry picked from commit 9f39148)
This fixes the patch phase. I missed this problem in NixOS#83956. (cherry picked from commit 36c7123)
This patch was also backported to M81 [0][1]. [0]: https://chromium-review.googlesource.com/c/chromium/src/+/2091896 [1]: chromium/chromium@bbf0fad (cherry picked from commit ff3bc51)
https://chromereleases.googleblog.com/2020/04/stable-channel-update-for-desktop_7.html This update includes 32 security fixes. CVEs: CVE-2020-6454 CVE-2020-6423 CVE-2020-6455 CVE-2020-6430 CVE-2020-6456 CVE-2020-6431 CVE-2020-6432 CVE-2020-6433 CVE-2020-6434 CVE-2020-6435 CVE-2020-6436 CVE-2020-6437 CVE-2020-6438 CVE-2020-6439 CVE-2020-6440 CVE-2020-6441 CVE-2020-6442 CVE-2020-6443 CVE-2020-6444 CVE-2020-6445 CVE-2020-6446 CVE-2020-6447 CVE-2020-6448 (cherry picked from commit da832dd)
|
@primeos can you elaborate on the |
|
@flokli of course. Tbh, I actually only add it to save @GrahamcOfBorg resources, as the build would timeout anyway. But if I think about it we probably have sufficient resources anyway (though sometimes the queuing times go up, IIRC) and it's probably a bit confusing. I can stop using it in future Chromium PRs if you want. Edit: But if I think about it, it also makes some sense as we're still testing this PR. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Backport of #84671.
Testing status
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)