Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fmt: 6.1.2 -> 6.2.0 #84771

Merged
merged 1 commit into from Apr 24, 2020
Merged

fmt: 6.1.2 -> 6.2.0 #84771

merged 1 commit into from Apr 24, 2020

Conversation

r-ryantm
Copy link
Contributor

@r-ryantm r-ryantm commented Apr 9, 2020

Semi-automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/fmtlib/fmt/releases.

meta.description for fmt is: "Small, safe and fast formatting library"

meta.homepage for fmt is: "http://fmtlib.net/"

Updates performed:

  • Version update
  • Quoted meta.homepage for RFC 45

Release on GitHub

Compare changes on GitHub

Checks done (click to expand)
Rebuild report (if merged into master) (click to expand)

69 total rebuild path(s)

20 package rebuild(s)

20 x86_64-linux rebuild(s)
19 i686-linux rebuild(s)
11 x86_64-darwin rebuild(s)
19 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
fmt
kodi
kodi-gbm
kodi-wayland
kodiGBM
kodiPlain
kodiPlainWayland
kodiPlugins.inputstream-adaptive
kodiPlugins.joystick
kodiPlugins.kodi
kodiPlugins.kodi-platform
kodiPlugins.pvr-hdhomerun
kodiPlugins.pvr-hts
kodiPlugins.pvr-iptvsimple
kodiPlugins.steam-controller
kodiPlugins.vfs-libarchive
kodiPlugins.vfs-sftp
mkvtoolnix
mkvtoolnix-cli
waybar

Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/0f9xasj662d5l5v6hvaxpk4n8crhx33j-fmt-6.2.0 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A fmt https://github.com/r-ryantm/nixpkgs/archive/e883a3a6941191e40a91f2d1c31bad7575e657fb.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/0f9xasj662d5l5v6hvaxpk4n8crhx33j-fmt-6.2.0
ls -la /nix/store/0f9xasj662d5l5v6hvaxpk4n8crhx33j-fmt-6.2.0/bin

cc @jeroendehaas for testing.

@ofborg ofborg bot requested a review from jeroendehaas April 9, 2020 03:21
@CloudArtAdmins
Copy link
Contributor

This worked for me.

@IvarWithoutBones IvarWithoutBones mentioned this pull request Apr 23, 2020
Merged
10 tasks
@jtojnar jtojnar self-assigned this Apr 23, 2020
@Mic92
Copy link
Member

Mic92 commented Apr 23, 2020

@GrahamcOfBorg build fmt

@jtojnar
Copy link
Contributor

jtojnar commented Apr 23, 2020

kodi fail to build:

/build/source/xbmc/cores/VideoPlayer/DVDCodecs/Video/AddonVideoCodec.cpp:238:187:   required from here
/nix/store/d9vvjandibgxpjswpl487ja6gqcqjfw9-fmt-6.2.0-dev/include/fmt/format.h:2717:53: error: 'class fmt::v6::basic_printf_context<std::back_insert_iterator<fmt::v6::internal::buffer<char> >, char>' has no member named 'error_handler'
 2717 |                                                 ctx.error_handler());
      |                                                 ~~~~^~~~~~~~~~~~~
/nix/store/d9vvjandibgxpjswpl487ja6gqcqjfw9-fmt-6.2.0-dev/include/fmt/format.h:2720:65: error: cannot convert 'fmt::v6::basic_string_view<char>' to 'int'
 2720 |     value = internal::get_dynamic_spec<Handler>(ctx.arg(ref.val.name),
      |                                                         ~~~~~~~~^~~~
      |                                                                 |
      |                                                                 fmt::v6::basic_string_view<char>
In file included from /build/source/xbmc/utils/StringUtils.h:32,
                 from /build/source/xbmc/utils/Digest.h:18,
                 from /build/source/xbmc/addons/Repository.h:16,
                 from /build/source/xbmc/addons/AddonManager.h:13,
                 from /build/source/xbmc/addons/binary-addons/BinaryAddonManager.h:11,
                 from /build/source/xbmc/addons/binary-addons/AddonDll.h:11,
                 from /build/source/xbmc/addons/binary-addons/AddonInstanceHandler.h:11,
                 from /build/source/xbmc/cores/VideoPlayer/DVDCodecs/Video/AddonVideoCodec.h:13,
                 from /build/source/xbmc/cores/VideoPlayer/DVDCodecs/Video/AddonVideoCodec.cpp:9:
/nix/store/d9vvjandibgxpjswpl487ja6gqcqjfw9-fmt-6.2.0-dev/include/fmt/printf.h:363:22: note:   initializing argument 1 of 'fmt::v6::basic_printf_context<OutputIt, Char>::format_arg fmt::v6::basic_printf_context<OutputIt, Char>::arg(int) const [with OutputIt = std::back_insert_iterator<fmt::v6::internal::buffer<char> >; Char = char; fmt::v6::basic_printf_context<OutputIt, Char>::format_arg = fmt::v6::basic_format_arg<fmt::v6::basic_printf_context<std::back_insert_iterator<fmt::v6::internal::buffer<char> >, char> >]'
  363 |   format_arg arg(int id) const { return args_.get(id); }
      |                  ~~~~^~
In file included from /build/source/xbmc/utils/StringUtils.h:29,
                 from /build/source/xbmc/utils/Digest.h:18,
                 from /build/source/xbmc/addons/Repository.h:16,
                 from /build/source/xbmc/addons/AddonManager.h:13,
                 from /build/source/xbmc/addons/binary-addons/BinaryAddonManager.h:11,
                 from /build/source/xbmc/addons/binary-addons/AddonDll.h:11,
                 from /build/source/xbmc/addons/binary-addons/AddonInstanceHandler.h:11,
                 from /build/source/xbmc/cores/VideoPlayer/DVDCodecs/Video/AddonVideoCodec.h:13,
                 from /build/source/xbmc/cores/VideoPlayer/DVDCodecs/Video/AddonVideoCodec.cpp:9:
/nix/store/d9vvjandibgxpjswpl487ja6gqcqjfw9-fmt-6.2.0-dev/include/fmt/format.h:2721:53: error: 'class fmt::v6::basic_printf_context<std::back_insert_iterator<fmt::v6::internal::buffer<char> >, char>' has no member named 'error_handler'
 2721 |                                                 ctx.error_handler());
      |                                                 ~~~~^~~~~~~~~~~~~
make[2]: *** [build/cores/VideoPlayer/codecs/video/CMakeFiles/dvdvideocodecs.dir/build.make:80: build/cores/VideoPlayer/codecs/video/CMakeFiles/dvdvideocodecs.dir/AddonVideoCodec.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:9541: build/cores/VideoPlayer/codecs/video/CMakeFiles/dvdvideocodecs.dir/all] Error 2

@jtojnar
Copy link
Contributor

jtojnar commented Apr 23, 2020

looks like xbmc/xbmc#17629 fmtlib/fmt#1620

cc Kodi maintainers @domenkozar @titanous @edwtjo @peterhoeg @sephalon

@jtojnar jtojnar removed their assignment Apr 23, 2020
@jtojnar
Copy link
Contributor

jtojnar commented Apr 23, 2020

@GrahamcOfBorg eval

@jtojnar jtojnar self-assigned this Apr 23, 2020
@jtojnar jtojnar removed their assignment Apr 23, 2020
@jtojnar
Copy link
Contributor

jtojnar commented Apr 23, 2020

@GrahamcOfBorg build kodi

@peterhoeg
Copy link
Member

The fix for kodi: xbmc/xbmc#17683

@jtojnar
Copy link
Contributor

jtojnar commented Apr 24, 2020

The fmt patch I added supposedly fixes it on fmt side but kodi takes ages to build so I did not verify it yet.

jtojnar
jtojnar approved these changes Apr 24, 2020
View reviewed changes
Copy link
Contributor

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Changes look reasonable
  • Reverse dependencies build (nix-build -A kodi-gbm -A waybar -A kodiPlugins.joystick -A kodiPlugins.kodi -A mkvtoolnix-cli -A kodiPlugins.pvr-iptvsimple -A kodiPlain -A kodiPlugins.inputstream-adaptive -A fmt -A kodi-wayland -A kodiPlainWayland -A kodiPlugins.pvr-hts -A kodi -A kodiPlugins.kodi-platform -A mkvtoolnix -A kodiGBM -A kodiPlugins.pvr-hdhomerun -A kodiPlugins.steam-controller -A kodiPlugins.vfs-sftp -A kodiPlugins.vfs-libarchive) so nothing probably depends on the newly deprecated API: FMT_DEPRECATED_INCLUDE_OS.

@jtojnar jtojnar merged commit 5e6adf7 into NixOS:master Apr 24, 2020
@r-ryantm r-ryantm deleted the auto-update/fmt branch May 2, 2020 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar approved these changes

@jeroendehaas jeroendehaas Awaiting requested review from jeroendehaas

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@r-ryantm @CloudArtAdmins @Mic92 @jtojnar @peterhoeg