Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/hydra
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 4cabb37ebdea
Choose a base ref
...
head repository: NixOS/hydra
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: d81650381456
Choose a head ref
  • 2 commits
  • 1 file changed
  • 1 contributor

Commits on Apr 8, 2020

  1. Separate the build IDs in the build_finished payload with tabs 

    hydra-notify splits the payload on tabs so we shouldn't separate the
IDs with spaces.
    @basvandijk
    basvandijk committed Apr 8, 2020
    Copy the full SHA
    6e35818 View commit details

  2. Merge pull request #733 from basvandijk/fix-build_finished-notifications 

    Separate the build IDs in the build_finished payload with tabs
    @basvandijk
    basvandijk authored Apr 8, 2020
    Copy the full SHA
    d816503 View commit details
Showing with 2 additions and 2 deletions.
  1. +2 −2 src/hydra-queue-runner/hydra-queue-runner.cc
4 changes: 2 additions & 2 deletions src/hydra-queue-runner/hydra-queue-runner.cc
View file
Original file line number Diff line number Diff line change
@@ -468,9 +468,9 @@ void State::notifyBuildStarted(pqxx::work & txn, BuildID buildId)
void State::notifyBuildFinished(pqxx::work & txn, BuildID buildId,
const std::vector<BuildID> & dependentIds)
{
auto payload = fmt("%d ", buildId);
auto payload = fmt("%d", buildId);
for (auto & d : dependentIds)
payload += fmt("%d ", d);
payload += fmt("\t%d", d);
// FIXME: apparently parameterized() doesn't support NOTIFY.
txn.exec(fmt("notify build_finished, '%s'", payload));
}