Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

device-tree_rpi: fix platforms #84738

Closed
wants to merge 1 commit into from
Closed

device-tree_rpi: fix platforms #84738

wants to merge 1 commit into from

Conversation

cleverca22
Copy link
Contributor

(cherry picked from commit 70308c5)

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cleverca22
device-tree_rpi: fix platforms
7c1a61a 
(cherry picked from commit 70308c5)
@cleverca22 cleverca22 mentioned this pull request Apr 9, 2020
Closed
@kwohlfahrt kwohlfahrt self-requested a review April 30, 2020 10:56
kwohlfahrt
kwohlfahrt approved these changes Apr 30, 2020
View reviewed changes
Copy link
Contributor

@kwohlfahrt kwohlfahrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This package will probably be obsoleted by queued changes to the device-tree code, so might be gone in the next release cycle. Is there a proper way to deprecate a package, or are they generally just removed?

@Mic92
Copy link
Member

Mic92 commented Apr 30, 2020

This is the wrong branch. Should be on release-20.03.

@Mic92
Copy link
Member

Mic92 commented Apr 30, 2020

LGTM. This package will probably be obsoleted by queued changes to the device-tree code, so might be gone in the next release cycle. Is there a proper way to deprecate a package, or are they generally just removed?

We have pkgs/top-level/aliases.nix for package deprecations.

@stale
Copy link

stale bot commented Oct 28, 2020

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 28, 2020
@Mic92
Copy link
Member

Mic92 commented Oct 28, 2020

This is now obsolete.

@Mic92 Mic92 closed this Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwohlfahrt kwohlfahrt kwohlfahrt approved these changes

Assignees
No one assigned
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cleverca22 @Mic92 @kwohlfahrt