Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

php.buildEnv: Don't inherit dev from the original php #84721

Merged
merged 1 commit into from Apr 8, 2020
Merged

php.buildEnv: Don't inherit dev from the original php #84721

merged 1 commit into from Apr 8, 2020

Conversation

talyz
Copy link
Contributor

@talyz talyz commented Apr 8, 2020

Motivation for this change

mkDerivation uses the dev output in buildInputs if it exits, hence the php-with-extensions package was never built or put into the path of packages dependent on it during build.

With this fix, the php packages built with buildEnv or withExtensions don't have any dev outputs; packages which need the dev output can refer to the phpXXbase packages instead.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@talyz
php.buildEnv: Don't inherit dev from the original php
472d5c1 
mkDerivation uses the dev output in buildInputs if it exits, hence the
php-with-extensions package was never built or put into the path of
packages dependent on it during build. With this fix, the php packages
built with buildEnv or withExtensions don't have any dev outputs;
packages which need the dev output can refer to the phpXXbase packages
instead.
@talyz talyz requested a review from etu as a code owner April 8, 2020 14:13
@talyz talyz mentioned this pull request Apr 8, 2020
Merged
10 tasks
@ofborg ofborg bot requested a review from Izorkin April 8, 2020 14:20
@etu etu merged commit 2589801 into NixOS:master Apr 8, 2020
@Ma27
Copy link
Member

Ma27 commented Apr 8, 2020

awesome, thanks!

@talyz talyz deleted the php-dont-inherit-dev branch April 9, 2020 08:04
@etu etu mentioned this pull request Apr 11, 2020
Merged
10 tasks
@talyz talyz mentioned this pull request May 17, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etu etu Awaiting requested review from etu

@Izorkin Izorkin Awaiting requested review from Izorkin

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@talyz @Ma27 @etu