Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/wireguard: Fix typo in error message #81907

Merged
merged 1 commit into from Mar 6, 2020
Merged

nixos/wireguard: Fix typo in error message #81907

merged 1 commit into from Mar 6, 2020

Conversation

atlaua
Copy link
Contributor

@atlaua atlaua commented Mar 6, 2020 •
edited

generatePrivateKey -> generatePrivateKeyFile

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@atlaua
nixos/wireguard: Fix typo in error message
b19c485 
generatePrivateKey -> generatePrivateKeyFile
lsix
lsix approved these changes Mar 6, 2020
View reviewed changes
Copy link
Member

@lsix lsix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

Thanks for spotting this!

Everything looks fine for me!

@lsix lsix merged commit 74c0ce5 into NixOS:master Mar 6, 2020
@lsix
Copy link
Member

lsix commented Mar 6, 2020

ported in release-20.03

@atlaua atlaua deleted the lr/wg-typo branch March 9, 2020 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsix lsix lsix approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@atlaua @lsix @Janik-Haag