shellcheck: add manpage and docs #81877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The shellcheck source code contains a manpage, so let’s add that to the output. For good measure, also copy the README to the doc output. The overrideMeta thing is taking care of setting the right position, so that `nix edit` points to this file instead of to the original haskellPackages definition.
Ma27
approved these changes
Mar 6, 2020
jtojnar
reviewed
Mar 7, 2020
|
|
||
| installPhase = '' | ||
| install -Dm755 ${bin}/bin/shellcheck $bin/bin/shellcheck | ||
| install -Dm644 README.md $doc/share/shellcheck/README.md |
There was a problem hiding this comment.
Would not it make more sense to just do this in postInstall in https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/haskell-modules/configuration-common.nix?
There was a problem hiding this comment.
Maybe, I don’t want to touch that tbh.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The shellcheck source code contains a manpage, so let’s add that to
the output. For good measure, also copy the README to the doc output.
The overrideMeta thing is taking care of setting the right position,
so that
nix editpoints to this file instead of to the originalhaskellPackages definition.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)