Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo-asm: 0.1.17 -> 2019-12-24 #81911

Merged
merged 1 commit into from Mar 29, 2020
Merged

Conversation

danieldk
Copy link
Contributor

@danieldk danieldk commented Mar 6, 2020

Motivation for this change

cargo-asm hasn't seen any new releases since 2018 (and even then
it was spotty). But there have been improvements since then, so
switch to dated releases that use a working git commit.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cargo-asm hasn't seen any new releases since 2018 (and even then
it was spotty). But there have been improvements since then, so
switch to dated releases that use a working git commit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants