Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

notable: 1.7 -> 1.8 #81912

Merged
merged 1 commit into from Mar 6, 2020
Merged

notable: 1.7 -> 1.8 #81912

merged 1 commit into from Mar 6, 2020

Conversation

ajs124
Copy link
Member

@ajs124 ajs124 commented Mar 6, 2020

Motivation for this change

cc @dtzWill

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from dtzWill March 6, 2020 17:57
lsix
lsix approved these changes Mar 6, 2020
View reviewed changes
Copy link
Member

@lsix lsix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built and tested.

Maybe, you could update the meta.homepage attribute and use quoted notation (c.f. RFC45)

Thanks

@lsix lsix self-requested a review March 6, 2020 18:34
lsix
lsix requested changes Mar 6, 2020
View reviewed changes
Copy link
Member

@lsix lsix left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, can the commit message be changed to notable: 1.7.3 -> 1.8.4 to more accurately reflect the change?

@ajs124
Copy link
Member Author

ajs124 commented Mar 6, 2020

done

@lsix lsix self-requested a review March 6, 2020 22:32
@lsix
Copy link
Member

lsix commented Mar 6, 2020

Perfect. Thanks.

@lsix lsix merged commit 8ff4f52 into NixOS:master Mar 6, 2020
@lsix
Copy link
Member

lsix commented Mar 6, 2020

I went to the github repo, and apparently, it is not released under a free software license anymore (https://github.com/notable/notable/blob/master/SOURCE_CODE.md). License changed after version 1.5.

I’ll create a PR to change the meta attribute.

@lsix
Copy link
Member

lsix commented Mar 6, 2020

(see #81932)

@ajs124 ajs124 deleted the upd/notable branch March 6, 2020 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsix lsix lsix approved these changes

@dtzWill dtzWill Awaiting requested review from dtzWill

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ajs124 @lsix