Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crystal: 0.32.1 -> 0.33.0 #81946

Closed
wants to merge 1 commit into from
Closed

crystal: 0.32.1 -> 0.33.0 #81946

wants to merge 1 commit into from

Conversation

djmaze
Copy link
Contributor

@djmaze djmaze commented Mar 7, 2020 •
edited

Motivation for this change

Update crystal to latest version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

JeffLabonte
JeffLabonte reviewed Mar 7, 2020
View reviewed changes
Copy link
Contributor

@JeffLabonte JeffLabonte left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't build on NixOS 19.09, here is the error:

[6 built (1 failed), 49 copied (1088.9 MiB), 199.6 MiB DL]
error: build of '/nix/store/zdc3cx6ygfrhlz71ap1cd4zd3b6d7s50-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/81946
1 package marked as broken and skipped:
icr

7 package failed to build:
ameba crystal crystal2nix gitAndTools.thicket mint scry shards

[0.0 MiB DL]
error: build log of '/nix/store/dm3cswmmn56j764sjm04irzhvvry2hxz-ameba-0.11.0.drv' is not available
[0.0 MiB DL]
error: build log of '/nix/store/rgqjqcgin7hfwq1qvsxjl7c73li4md8g-crystal2nix-unstable-2018-07-31.drv' is not available
[0.0 MiB DL]
error: build log of '/nix/store/a7k47iczax4g2l94z1ifnk910pl5h67x-thicket-0.1.3.drv' is not available
[0.0 MiB DL]
error: build log of '/nix/store/6qh1kxh8i0nadw14v16ay2mgsi8zvn06-mint-0.7.1.drv' is not available
[0.0 MiB DL]
error: build log of '/nix/store/c1rm3i3ikka7jhdp52k18ksx4xzd921m-scry-0.8.1.drv' is not available
[0.0 MiB DL]
error: build log of '/nix/store/sgljhw4wk6z75jbs38jlb1y7bpfm0ib7-shards-0.9.0.drv' is not available

@djmaze
Copy link
Contributor Author

djmaze commented Mar 7, 2020

Forgive me, I am not yet a Nix* expert. How can I get your above output? I can build all the other mentioned packages successfully in my nixpkgs checkout on my NixOS 19.09 machine (using nix-build -A <package>). Apart from icr, which fails with Support for OpenSSL 1.0.2 ended with 2019. But that fails for me on master as well.

You see, I probably need a bit of guidance on this..

@JeffLabonte
Copy link
Contributor

I ran the following command : nix-shell -p nixpkgs-review --run "nixpkgs-review pr 81946"

It can be found in the nixpkgs manual.

From what I have read in the doc, you should be able to run nixpkgs-review in your project with:

nix run nixpkgs.nixpkgs-review -c nixpkgs-review rev HEAD

For the broken package, I am not an expert as well, I would recommend you to ask for help on nixos discourse.

Thank you for contributing to the project! :)

@peterhoeg
Copy link
Member

Superseded by #85432

@peterhoeg peterhoeg closed this Apr 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeffLabonte JeffLabonte JeffLabonte left review comments

@manveru manveru Awaiting requested review from manveru

@peterhoeg peterhoeg Awaiting requested review from peterhoeg

@david50407 david50407 Awaiting requested review from david50407

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@djmaze @JeffLabonte @peterhoeg